On Wed, 18 Apr 2018 02:13:25 +0000 YEONGJONG LEE <clean...@gmail.com> said:
that change looks correct. it's returning a const which implies don't free it - it's constant (it isn't - it's actually just the internal list). > Hello, > > I'm sure this is right. > See https://phab.enlightenment.org/D5953 > > Sorry, i forgot to revise commit title :( > > Regards > Yeongjong Lee > > -------- 원본 이메일 -------- > 보낸 사람: Stefan Schmidt <ste...@osg.samsung.com> > 날짜: 18/4/17 오후 3:11 (GMT+09:00) > 받은 사람: Enlightenment developer list < > enlightenment-devel@lists.sourceforge.net>, YeongJong Lee < > yj34....@samsung.com> > 제목: Re: [E-devel] [EGIT] [core/efl] master 01/01: elm_dbus_menu: add > missing const for Eina_List > > Hello. > > > On 04/17/2018 04:10 AM, YeongJong Lee wrote: > > sanghyeonlee pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=c943c4a2ffd51d9c7a1f4dd95f99721b1cb9148e > > > > commit c943c4a2ffd51d9c7a1f4dd95f99721b1cb9148e > > Author: YeongJong Lee <yj34....@samsung.com> > > Date: Tue Apr 17 11:08:25 2018 +0900 > > > > elm_dbus_menu: add missing const for Eina_List > > > > Summary: > > This fixes following warning > > > > ../src/lib/eina/eina_list.h:1421:10: warning: assignment discards > ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] > > > > Test Plan: make > > > > Reviewers: SanghyeonLee > > > > Reviewed By: SanghyeonLee > > > > Subscribers: cedric > > > > Differential Revision: https://phab.enlightenment.org/D5952 > > --- > > src/lib/elementary/elm_dbus_menu.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/src/lib/elementary/elm_dbus_menu.c > b/src/lib/elementary/elm_dbus_menu.c > > index 0bf096347d..73b8a7bf0b 100644 > > --- a/src/lib/elementary/elm_dbus_menu.c > > +++ b/src/lib/elementary/elm_dbus_menu.c > > @@ -333,8 +333,7 @@ _root_layout_build(Elm_DBus_Menu *dbus_menu, > Eina_List *property_list, > > { > > char *property; > > Eldbus_Message_Iter *layout, *array, *pair, *variant; > > - Eina_List *l; > > - const Eina_List *it; > > + const Eina_List *l, *it; > > Elm_Object_Item *obj_item; > > > > layout = eldbus_message_iter_container_new(iter, 'r', NULL); > > @@ -422,8 +421,7 @@ _elm_dbus_menu_add(Eo *menu) > > { > > Elm_DBus_Menu *dbus_menu; > > Elm_Object_Item *obj_item; > > - const Eina_List *it; > > - Eina_List *l; > > + const Eina_List *it, *l; > > > > ELM_MENU_CHECK(menu) NULL; > > > > @@ -457,7 +455,6 @@ _elm_dbus_menu_add(Eo *menu) > > return dbus_menu; > > > > error_hash: > > - eina_iterator_free(it); > > eina_hash_free(dbus_menu->elements); > > error_menu: > > free(dbus_menu); > > > > You commit message does only mention adding the const qualifier but nothing > about this iterator free you remove. > > Are you sure this is right or has this been committed accidentally? > > regards > Stefan Schmidt > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -------- 원본 이메일 --------보낸 사람: Stefan Schmidt > <ste...@osg.samsung.com> 날짜: 18/4/17 오후 3:11 (GMT+09:00) 받은 사람: > Enlightenment developer list < enlightenment-devel@lists.sourceforge.net>, > YeongJong Lee < yj34....@samsung.com> 제목: Re: [E-devel] [EGIT] [core/efl] > master 01/01: elm_dbus_menu: add missing const for Eina_List > Hello. > > > On 04/17/2018 04:10 AM, YeongJong Lee wrote: > > sanghyeonlee pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=c943c4a2ffd51d9c7a1f4dd95f99721b1cb9148e > > > > commit c943c4a2ffd51d9c7a1f4dd95f99721b1cb9148e > > Author: YeongJong Lee <yj34....@samsung.com> > > Date: Tue Apr 17 11:08:25 2018 +0900 > > > > elm_dbus_menu: add missing const for Eina_List > > > > Summary: > > This fixes following warning > > > > ../src/lib/eina/eina_list.h:1421:10: warning: assignment discards > ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] > > > > Test Plan: make > > > > Reviewers: SanghyeonLee > > > > Reviewed By: SanghyeonLee > > > > Subscribers: cedric > > > > Differential Revision: https://phab.enlightenment.org/D5952 > > --- > > src/lib/elementary/elm_dbus_menu.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/src/lib/elementary/elm_dbus_menu.c > b/src/lib/elementary/elm_dbus_menu.c > > index 0bf096347d..73b8a7bf0b 100644 > > --- a/src/lib/elementary/elm_dbus_menu.c > > +++ b/src/lib/elementary/elm_dbus_menu.c > > @@ -333,8 +333,7 @@ _root_layout_build(Elm_DBus_Menu *dbus_menu, > Eina_List *property_list, > > { > > char *property; > > Eldbus_Message_Iter *layout, *array, *pair, *variant; > > - Eina_List *l; > > - const Eina_List *it; > > + const Eina_List *l, *it; > > Elm_Object_Item *obj_item; > > > > layout = eldbus_message_iter_container_new(iter, 'r', NULL); > > @@ -422,8 +421,7 @@ _elm_dbus_menu_add(Eo *menu) > > { > > Elm_DBus_Menu *dbus_menu; > > Elm_Object_Item *obj_item; > > - const Eina_List *it; > > - Eina_List *l; > > + const Eina_List *it, *l; > > > > ELM_MENU_CHECK(menu) NULL; > > > > @@ -457,7 +455,6 @@ _elm_dbus_menu_add(Eo *menu) > > return dbus_menu; > > > > error_hash: > > - eina_iterator_free(it); > > eina_hash_free(dbus_menu->elements); > > error_menu: > > free(dbus_menu); > > > > You commit message does only mention adding the const qualifier but nothing > about this iterator free you remove. > > Are you sure this is right or has this been committed accidentally? > > regards > Stefan Schmidt > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- Carsten Haitzler - ras...@rasterman.com ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
