On Fri, Oct 25, 2019 at 5:44 AM Xavi Artigas <xavierarti...@gmail.com> wrote: > > > > > As for having an error_return flag/type, this also seems fine from a > > functional and documentation perspective, though it feels a bit strange and > > not-intuitive to have a different keyword/return type specific to property > > set methods than is used for methods which return bool. > > > > We could use this error_flag everywhere, not just in properties. Since it's > actually an Eina_Bool, there's no API break. > I currently like this idea better than custom eolian tags, for reasons > discussed in > https://phab.enlightenment.org/D10432 > > We need to take a decision so, unless anybody has anything against it, > we'll start working on the boolean-alias idea next week: > https://phab.enlightenment.org/T8383
IMO, D10432 is important for various reasons, but is not a very good idea for treating bools for errors. IMO, we should just use a typedef for a known type which generators can use to know that it means error, and the typedef documentation can mention if false means error, or true means error. Which Eina_Bool is not explicit about. > Xavi > Regards, -- Felipe Magno de Almeida _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
