On Jan 13, 2008 6:16 PM, Adriano Rezende <[EMAIL PROTECTED]> wrote:
> On Jan 13, 2008 3:03 PM, Andreas Volz <[EMAIL PROTECTED]> wrote:
>
> > Am Sat, 12 Jan 2008 19:44:40 -0300 schrieb Adriano Rezende:
> >
> >
> > > I believe you have to emit the signal to
> > > sd->editable_object->text_object
> > >
> > > Search for the following code in your e_entry.c
> > >
> > > | sd->editable_object = o;
> > > | e_editable_theme_set(o, "base/theme/widgets", "e/widgets/entry");
> > >
> > > and follow the method e_editable_theme_set.
> > >
> > > I just took a fast look at the code, so I recommend to test before.
> >
> > Thanks for that hint. I did a better patch and it works now. I think
> > the visual improvement is really nice.
> >
> > http://tux-style.de/tmp/tclock_deactivated_gray.png
> >
> > Now users could see that a text entry is deactivated.
> >
> > I've created a new bug entry about that topic:
> >
> > http://bugzilla.enlightenment.org/show_bug.cgi?id=357
> >
> > Please review the patch if possible. Commit it or allow me to commit if
> > the patch looks good.
>
> Sorry, I don't work on this project.
> But probably the owner will see the patch and apply the changes.

:-)

Andreas,

Patch looks really small and yes, maybe applied by raster one he have
the time to check.

As I'm not used to E code, just found something weird with the existing code:

    edje_object_signal_emit(entry, "e,state,enabled", "e");

since entry is not (at least looks like it's not) an Edje object, this
will have no effect due defensive programming,
edje_object_signal_emit() will find no "Edje *" with
"_edje_fetch(obj)" and then will return.

I just noticed that because I think the signal should be sent to
sd->entry_object, not sd->editable_object, it would allow us even to
set a clipper and make it transparent, thus disabled items could be
semi-transparent! :-)

If I'm right and the above code is bogus, then it's just a matter of
using sd->entry_object instead of entry, add the theme part and we're
done.


-- 
Gustavo Sverzut Barbieri
--------------------------------------
Jabber: [EMAIL PROTECTED]
   MSN: [EMAIL PROTECTED]
  ICQ#: 17249123
 Skype: gsbarbieri
Mobile: +55 (81) 9927 0010

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to