On Fri, 18 Jan 2008 00:27:44 +0100 "Massimiliano Calamelli" <[EMAIL PROTECTED]> babbled:
ok first the bad (it's short): 1. initial size of the dialog is tiny - no space for the website list or thumbail list. need to have it be a sane size at the start. 2. you have parse bugs and segv's. use valgrind and see :) 3. i might just rename "websites" button to "online" - really minor, and "websites" frame to "sources". so you need to fix #1 and #2 first :) 3 is minor. now the good. this is fantastic. nice nice nice! i had hoped to eventually get to this - maybe in e18. bringing in "online content" in a very easy way. veeeery nice!. this of course opens a bit of a floodgate. for now - lets not do themes and other things. lets ONLY make an online wallpaper fetcher and make it good - use it as our prototype/test case. many things here come out of this can of worms. 1. http procies. yes libcurl will use HTTP_PROXY environment vars - but there is no way for a user to set this with e - they have to edit their shell env. we probably need to have e be able to set this env var itself from its own config - if the user desires to have a proxy set. a proxy config settign in e and a config module to set it would be good/useful here. 2. no way to add more sites (yet) need this. a user should be able to type in a url, and if the site handles the same RSS feed format and data - then it should work. this would allow for other people to provide their own "data" feeds online. 3. i'd LOVE to see a way for a user to... SUBMIT content. lets say they make a nice wallpaper of their own - they want to submit it for the repository/feed - they just press the "submit" button and the code does the rest (does an http post or upload with the data etc.) 4. as suggested bu laurent - being able to vote a wallpaper as good or bad - or any content might be nice. 5. you want to make a .tmp/ directory in the download dir for the thumbnails/previews. why? AS they download efm will keep getting "file changed" events and keep trying to generate thumbnails. you want to create an invisible .tmp/ dir and download into there - then when the download is done, rename() (mv) the file from the .tmp dir into the parent. then it will appear in 1 go when done cleanly and efficiently. renames are atomic in unix so this should be exactly what you need 6. this may lead to wanting to make a much more abstracted bit of code for downloading and previewing content. so we could have a core piece of shared code that does the: * rss fetching, caching, parsing and building of a list of content to download * downloading of previews, generating a directory of preview content with filenames and the whole rename() and .tmp dir stuff as well as caching. * downloading of the real content once selected and any download status (progress/whatever) as needed. * handles a generic way to submit content * handles a generic way to add new repositories via a dialog and a user typing in a URL * have a central list of all known repositories also online somewhere (get-e.org or enlightenment.org) and a way for anyone to submit their repo to it. this way users can update/get new repositories whenever they become available. as long as we make it really fast & easy to have your repository added without fuss - this should work well. note - i don't see this as a must for e17 - but if this can get done nicely and well before e17 release - i am more than happy to include it. once we have this right and done well for wallpapers we can expand to themes, icons and anything else - even modules (this gets a bit complex as u need to have the module compiled for your particular architecture/os or u have to compile it after download which is just nasty). so you basically have done something that is fairly small and simple - but incredibly cool and with a huge amount of potential. > Hi, here's the result of my first work on E's internals (and widgets): > i wrote a simple addon that allow to select a wallpaper directly from > get-e.org, actually only from static backgrounds. > > Requirements: > ecore_file with libcurl support(updated > 14 january) > > How it works: > My module get and parse a RSS feed from get-e.org, obtaining a list of > images of static backgrounds that actually are available on get-e.org, > downloading all images and shows it in efm. When you choose an image > and click OK, the module get the real background you've choose, > already in edj format, and copy it into ~/.e/e/backgrounds. Now the > new wallpaper is available in the first window of wallpaper > configuration dialog. > > Status: > This is a preview. It works (just tested 5 minutes ago), and it works > fine also without DSL connection (i'm testing it with GPRS/UMTS). I'm > sure that something can be done in a better way, and it miss some cool > features, like caching of results to avoid useless connections, and > proxy support (i'm not sure but i think that it will be done by > libcurl internals). > > Todo: > Implement a way to use a image cache to avoid connections > Test in proxy environment > Animated backgrounds support > Other sites support (Flickr,DeviantArt,...) > > Thanks: > devilhorns and morlenxus for initial support, exhibit's guys for > example code, raster for enthusiasm, kainx and englebass for support > to make the attached diff :) > > If you like this way to get backgrounds from get-e.org, there's two > other things that can be done easily in the same way: 0) animated > backgrounds, 1) themes. > Feel free to send a comment, to hate/love/commit it. > > Regards > > Massimiliano > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [EMAIL PROTECTED] ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel