On Mon, 21 Jan 2008 14:17:43 +0100 Massimiliano Calamelli <[EMAIL PROTECTED]> babbled:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Sat, 19 Jan 2008 12:56:21 +1100 > Carsten Haitzler (The Rasterman) <[EMAIL PROTECTED]> wrote: > > > ok first the bad (it's short): > > > > 1. initial size of the dialog is tiny - no space for the website list or > > thumbail list. need to have it be a sane size at the start. > > Do you think that can i use the same size of Gradient dialog? well you should set minimum size on the website and wallpaper thumbnail fm list - then the dialog can have a minimum size thats sane - all dialogs do this. > > 2. you have parse bugs and segv's. use valgrind and see :) > > Thx for tip! valgrind is your friend. learn it. love it. use it. become best friends with it. > > 3. i might just rename "websites" button to "online" - really minor, and > > "websites" frame to "sources". > > > > I agree, it's better. it's minor cosmetic stuff - but makes more sense in english. this stuff can be done as final polishes as its just text label changes. > > so you need to fix #1 and #2 first :) 3 is minor. > > > > now the good. > > > > this is fantastic. nice nice nice! i had hoped to eventually get to this - > > maybe in e18. bringing in "online content" in a very easy way. veeeery > > nice!. > > :) > > > > > this of course opens a bit of a floodgate. for now - lets not do themes and > > other things. lets ONLY make an online wallpaper fetcher and make it good - > > use it as our prototype/test case. many things here come out of this can of > > worms. > > Ok, sounds good for me. > > > > > 1. http procies. yes libcurl will use HTTP_PROXY environment vars - but > > there is no way for a user to set this with e - they have to edit their > > shell env. we probably need to have e be able to set this env var itself > > from its own config - if the user desires to have a proxy set. a proxy > > config settign in e and a config module to set it would be good/useful here. > > > > > 2. no way to add more sites (yet) need this. a user should be able to type > > in a url, and if the site handles the same RSS feed format and data - then > > it should work. this would allow for other people to provide their own > > "data" feeds online. > > We need a RSS/ATOM-parsing library for now - keep that code in your patches - but separate it out to be generic and possibly useful being split out later. so for now this can be the testbed for it, but if the api is done well, it can be easily stripped out and made into a library. > > 3. i'd LOVE to see a way for a user to... SUBMIT content. lets say they > > make a nice wallpaper of their own - they want to submit it for the > > repository/feed - they just press the "submit" button and the code does the > > rest (does an http post or upload with the data etc.) > > 4. as suggested bu laurent - being able to vote a wallpaper as good or bad > > - or any content might be nice. > > Great ideas, user interaction is very important (web2.0 way) yup - just minus the big fat bulky web browser bloat :) and that - i like :) > > 5. you want to make a .tmp/ directory in the download dir for the > > thumbnails/previews. why? AS they download efm will keep getting "file > > changed" events and keep trying to generate thumbnails. you want to create > > an invisible .tmp/ dir and download into there - then when the download is > > done, rename() (mv) the file from the .tmp dir into the parent. then it > > will appear in 1 go when done cleanly and efficiently. renames are atomic > > in unix so this should be exactly what you need > > I'll try to implement this way after solving "bad" things > > > 6. this may lead to wanting to make a much more abstracted bit of code for > > downloading and previewing content. so we could have a core piece of shared > > code that does the: > > * rss fetching, caching, parsing and building of a list of content to > > download > > * downloading of previews, generating a directory of preview content with > > filenames and the whole rename() and .tmp dir stuff as well as caching. > > * downloading of the real content once selected and any download status > > (progress/whatever) as needed. > > * handles a generic way to submit content > > * handles a generic way to add new repositories via a dialog and a user > > typing in a URL > > * have a central list of all known repositories also online somewhere > > (get-e.org or enlightenment.org) and a way for anyone to submit their repo > > to it. this way users can update/get new repositories whenever they become > > available. as long as we make it really fast & easy to have your repository > > added without fuss - this should work well. > > > > Agree > > > note - i don't see this as a must for e17 - but if this can get done nicely > > and well before e17 release - i am more than happy to include it. once we > > have this right and done well for wallpapers we can expand to themes, icons > > and anything else - even modules (this gets a bit complex as u need to have > > the module compiled for your particular architecture/os or u have to > > compile it after download which is just nasty). > > > > so you basically have done something that is fairly small and simple - but > > incredibly cool and with a huge amount of potential. > > I'm very happy to see that my work are appreciated, I hope to make it > better following your tips, and then make E better! > > Now a question: do you think that can be useful if ecore_file_download > can returns more than true or false, something like a HTTP status > response (404, 200, and other)? hmmm. personally i find it only useful that it downloaded or it didn't. but others might prefer lots of detailed info - the # of reasons could be many that it failed. > Massimiliano > - -- > Massimiliano Calamelli > http://mcalamelli.netsons.org > [EMAIL PROTECTED] > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.4 (MingW32) > > iD8DBQFHlJt4leGEL56NNP4RAisXAJ9yZ5fRm08X74fe463UtaZCXmWR1ACeKOBa > Jzk3qkNkVIQaIYAsgh12aa0= > =Nz3L > -----END PGP SIGNATURE----- > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [EMAIL PROTECTED] ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
