Hi,
A long over due mail with the OpenBSD specific patches inlined.
The files can be checked directly from
http://www.openbsd.org/cgi-bin/cvsweb/ports/x11/e17/
This in the -current system (http://www.openbsd.org/faq/faq5.html#Flavors).
This is based on a snapshot from 20071211.
In eet:
--- src/lib/eet_lib.c.orig Mon Nov 12 11:14:04 2007
+++ src/lib/eet_lib.c Mon Nov 12 11:15:11 2007
@@ -497,6 +497,10 @@ eet_open(const char *file, Eet_File_Mode mode)
else
return NULL;
}
+ else if (file_stat.st_size == 0)
+ {
+ return NULL;
+ }
/* We found one */
if (ef && (file_stat.st_mtime != ef->mtime))
Warnings:
Four warnings:about "HAVE_STDLIB_H" being redefined.
Two warning about unsafe function : strcpy and sprintf instead of
strlcpy and snprintf
In Evas:
$OpenBSD: patch-configure_in,v 1.1 2007/12/06 19:47:08 bernd Exp $
--- configure.in.orig Wed Dec 5 22:13:29 2007
+++ configure.in Wed Dec 5 22:13:42 2007
@@ -31,7 +31,7 @@ AC_SUBST(version_info)
AC_FUNC_ALLOCA
-MODULE_ARCH="$host_os-$host_cpu"
+MODULE_ARCH=""
AC_SUBST(MODULE_ARCH)
AC_DEFINE_UNQUOTED(MODULE_ARCH, "$MODULE_ARCH", "Module architecture")
$OpenBSD: patch-src_lib_include_evas_common_h,v 1.1 2007/12/07
09:49:58 mbalmer Exp $
--- src/lib/include/evas_common.h.orig Fri Dec 7 10:34:46 2007
+++ src/lib/include/evas_common.h Fri Dec 7 10:34:59 2007
@@ -46,6 +46,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
+#include <stdint.h>
#include <string.h>
#include <signal.h>
#include <setjmp.h>
Warnings:
evas_convert_rgb_8.c: In function
`evas_common_convert_rgba_to_8bpp_rgb_221_dith':
evas_convert_rgb_8.c:162: warning: right shift count is negative
evas_convert_rgb_8.c: In function
`evas_common_convert_rgba_to_8bpp_rgb_121_dith':
evas_convert_rgb_8.c:195: warning: right shift count is negative
evas_convert_rgb_8.c: In function
`evas_common_convert_rgba_to_8bpp_rgb_111_dith':
evas_convert_rgb_8.c:228: warning: right shift count is negative
and:
evas_outbuf.c: In function `evas_buffer_outbuf_buf_push_updated_region':
evas_outbuf.c:268: warning: assignment from incompatible pointer type
evas_outbuf.c:284: warning: assignment from incompatible pointer type
evas_outbuf.c:310: warning: assignment from incompatible pointer type
evas_outbuf.c:341: warning: assignment from incompatible pointer type
And:
evas_engine.c: In function `eng_font_draw':
evas_engine.c:855: warning: passing arg 3 of
`evas_common_draw_context_font_ext_set' from incompatible pointer type
evas_engine.c:855: warning: passing arg 4 of
`evas_common_draw_context_font_ext_set' from incompatible pointer type
evas_engine.c:855: warning: passing arg 5 of
`evas_common_draw_context_font_ext_set' from incompatible pointer type
evas_engine.c: In function `module_open':
evas_engine.c:926: warning: assignment from incompatible pointer type
and:
evas_engine_font.c: In function `_xre_font_surface_draw':
evas_engine_font.c:178: warning: comparison is always false due to
limited range of data type
evas_engine_font.c:178: warning: comparison is always false due to
limited range of data type
and:a couple of warnings about "HAVE_STDLIB_H" being redefined in the
jpg folder.
In ecore:
It seems ecore does not respect :--disable-ecore-evas-sdl
--disable-ecore-sdl and still links to SDL if it exist, can someone
please test this under linux.
Unsafe functions strcpy,sprintf and strcat instead of strlcpy,snprintf
and strlcat
In edje:
edje_data.c: In function `_edje_edd_setup':
edje_data.c:70: warning: assignment from incompatible pointer type
edje_data.c:72: warning: assignment from incompatible pointer type
edje_data.c:73: warning: assignment from incompatible pointer type
edje_data.c:74: warning: assignment from incompatible pointer type
edje_data.c:75: warning: assignment from incompatible pointer type
edje_data.c:76: warning: assignment from incompatible pointer type
edje_data.c:77: warning: assignment from incompatible pointer type
edje_data.c:78: warning: assignment from incompatible pointer type
Unsafe functions:strcpy and strcat.
In embryo:
unsafe functions: strcpy,sprintf and strcat.
In E:
--- configure.in.orig Wed Nov 7 11:45:47 2007
+++ configure.in Wed Dec 5 21:29:17 2007
@@ -70,7 +70,7 @@ AC_CHECK_HEADERS(security/pam_appl.h, [
AC_SUBST(VALGRIND_CFLAGS)
AC_SUBST(VALGRIND_LIBS)
-MODULE_ARCH="$host_os-$host_cpu"
+MODULE_ARCH=""
AC_SUBST(MODULE_ARCH)
AC_DEFINE_UNQUOTED(MODULE_ARCH, "$MODULE_ARCH", "Module architecture")
@@ -148,6 +148,9 @@ AC_SUBST(ALL_LINGUAS)
AM_GNU_GETTEXT([external])
AM_GNU_GETTEXT_VERSION([0.12.1])
+LIBICONV="$LTLIBICONV"
+LIBINTL="$LTLIBINTL"
+INTLLIBS="$LTLIBINTL"
if test "x$LIBINTL" = "x"; then
LIBINTL="$INTLLIBS"
fi
--- src/bin/Makefile.am.orig Fri Nov 9 16:20:53 2007
+++ src/bin/Makefile.am Fri Nov 9 16:21:15 2007
@@ -345,7 +345,7 @@ e_xinerama.c
enlightenment_init_LDFLAGS = @e_libs@
-setuid_root_mode = a=rx,u+xs
+setuid_root_mode = a=rx,u+x
install-exec-hook:
@chmod $(setuid_root_mode)
$(DESTDIR)$(bindir)/enlightenment_sys$(EXEEXT) || true
##This is only to disaable the moduyles because they are not yet
supported, work on this has been stalled.
--- src/bin/e_config.c.orig Fri Dec 20 17:07:06 2007
+++ src/bin/e_config.c Fri Dec 20 17:07:48 2007
@@ -766,9 +766,9 @@ e_config_init(void)
CFG_MODULE("ibox", 1, 0);
CFG_MODULE("dropshadow", 1, 0);
CFG_MODULE("clock", 1, 0);
- CFG_MODULE("battery", 1, 0);
- CFG_MODULE("cpufreq", 1, 0);
- CFG_MODULE("temperature", 1, 0);
+ CFG_MODULE("battery", 0, 0);
+ CFG_MODULE("cpufreq", 0, 0);
+ CFG_MODULE("temperature", 0, 0);
CFG_MODULE("pager", 1, 0);
CFG_MODULE("exebuf", 1, 1);
CFG_MODULE("winlist", 1, 1);
--- src/bin/e_fm.c.orig Wed Nov 7 11:45:43 2007
+++ src/bin/e_fm.c Fri Dec 7 15:44:09 2007
@@ -104,7 +104,7 @@ struct _E_Fm2_Smart_Data
E_Drop_Handler *drop_handler;
E_Fm2_Icon *drop_icon;
E_Fm2_Mount *mount;
- char drop_after;
+ signed char drop_after;
unsigned char drop_show : 1;
unsigned char drop_in_show : 1;
unsigned char drop_all : 1;
@@ -3214,7 +3214,7 @@ _e_fm2_uri_parse(const char *val)
p = val + 7;
if (*p != '/')
{
- for (i = 0; *p != '/' && *p != '\0' && i <
_POSIX_HOST_NAME_MAX; p++, i++)
+ for (i = 0; *p != '/' && *p != '\0' && i < MAXHOSTNAMELEN; p++, i++)
hostname[i] = *p;
}
hostname[i] = '\0';
@@ -3247,9 +3247,9 @@ _e_fm2_uri_path_list_get(Evas_List *uri_list)
{
E_Fm2_Uri *uri;
Evas_List *l, *path_list = NULL;
- char current_hostname[_POSIX_HOST_NAME_MAX];
+ char current_hostname[MAXHOSTNAMELEN];
- if (gethostname(current_hostname, _POSIX_HOST_NAME_MAX) == -1)
+ if (gethostname(current_hostname, MAXHOSTNAMELEN) == -1)
current_hostname[0] = '\0';
for (l = uri_list; l; l = l->next)
$OpenBSD: patch-src_bin_e_main_c,v 1.1 2007/12/04 17:43:15 bernd Exp $
The OpenBSD tar(1) doesn't have a -k option to preserve existing files.
Use pax(1) with its -k option.
--- src/bin/e_main.c.orig Mon Dec 3 13:59:16 2007
+++ src/bin/e_main.c Mon Dec 3 13:59:48 2007
@@ -1088,13 +1088,13 @@ _e_main_dirs_init(void)
{
snprintf(buf, sizeof(buf),
"gzip -d -c < %s/data/other/desktop_files.tar.gz | "
- "(cd %s/applications/ ; tar -xkf -)",
+ "(cd %s/applications/ ; /bin/pax -rk)",
e_prefix_data_get(),
efreet_data_home_get());
system(buf);
snprintf(buf, sizeof(buf),
"gzip -d -c < %s/data/other/desktop_order.tar.gz | "
- "(cd %s/.e/e/ ; tar -xkf -)",
+ "(cd %s/.e/e/ ; /bin/pax -rk)",
e_prefix_data_get(),
homedir);
system(buf);
@@ -1105,7 +1105,7 @@ _e_main_dirs_init(void)
{
snprintf(buf, sizeof(buf),
"gzip -d -c < %s/data/other/efm_favorites.tar.gz | "
- "(cd %s/.e/e/ ; tar -xkf -)",
+ "(cd %s/.e/e/ ; /bin/pax -rk)",
e_prefix_data_get(),
homedir);
system(buf);
--- src/modules/cpufreq/Makefile.am.orig Fri Nov 9 15:16:55 2007
+++ src/modules/cpufreq/Makefile.am Fri Nov 9 15:17:26 2007
@@ -28,7 +28,7 @@ freqsetdir = $(pkgdir)
freqset_DATA = \
freqset$(EXEEXT)
-setuid_root_mode = a=rx,u+xs
+setuid_root_mode = a=rx,u+x
install-data-hook:
@chmod $(setuid_root_mode)
$(DESTDIR)$(freqsetdir)/freqset$(EXEEXT) || true
Warnings:
Alot of unsafe functions.
e17 was tested under the following arch:
i386, amd64,zaurus,macppc.
Also many thanks to all the people that have helped
(patches/testing/etc), too numerous to mention here but you know who
you are.
Kind regards, Laurent.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
