Hi,
First off, i am not trying to push these patches, i was asked on IRC
to post them with some comments.
I did so.
On Jan 23, 2008 7:45 AM, Mike Frysinger <[EMAIL PROTECTED]> wrote:
> On Wednesday 23 January 2008, laurent FANIS wrote:
> > --- src/lib/eet_lib.c.orig Mon Nov 12 11:14:04 2007
> > +++ src/lib/eet_lib.c Mon Nov 12 11:15:11 2007
> > @@ -497,6 +497,10 @@ eet_open(const char *file, Eet_File_Mode mode)
> > else
> > return NULL;
> > }
> > + else if (file_stat.st_size == 0)
> > + {
> > + return NULL;
> > + }
> >
> > /* We found one */
> > if (ef && (file_stat.st_mtime != ef->mtime))
>
> should be an issue on all systems ... could you elaborate on what this fixes ?
> if you look up a few lines, there's already a stat size check.
>
> > Warnings:
> > Four warnings:about "HAVE_STDLIB_H" being redefined.
>
> *when* and *where* ... please post real build errors instead of describing
> them in snippets which lack context
>
Will do as soon as i have some free time.
> > Two warning about unsafe function : strcpy and sprintf instead of
> > strlcpy and snprintf
>
> all of these strl* warnings are bsd-specific obviously as they are
> bsd-specific functions
>
For future reference i did not checked all the functions, and i did
not patch them. And yeah usually the OpenBSD gcc-local bitches about
unsafe functions.
> > --- configure.in.orig Wed Dec 5 22:13:29 2007
> > +++ configure.in Wed Dec 5 22:13:42 2007
> > @@ -31,7 +31,7 @@ AC_SUBST(version_info)
> >
> > AC_FUNC_ALLOCA
> >
> > -MODULE_ARCH="$host_os-$host_cpu"
> > +MODULE_ARCH=""
> > AC_SUBST(MODULE_ARCH)
> > AC_DEFINE_UNQUOTED(MODULE_ARCH, "$MODULE_ARCH", "Module architecture")
> >
>
> ugh, this cant possibly be correct. can you explain what you're trying to
> fix. same goes for all the configure scripts you modified like this.
>
This is to be able to update cleanly the packages from one release to
another, this is OpenBSD specific.
> > --- src/lib/include/evas_common.h.orig Fri Dec 7 10:34:46 2007
> > +++ src/lib/include/evas_common.h Fri Dec 7 10:34:59 2007
> > @@ -46,6 +46,7 @@
> > #include <stdio.h>
> > #include <stdlib.h>
> > #include <unistd.h>
> > +#include <stdint.h>
> > #include <string.h>
> > #include <signal.h>
> > #include <setjmp.h>
>
> stdint.h should be everywhere ;)
>
It wasn't here and the compiler choked.
> > and:a couple of warnings about "HAVE_STDLIB_H" being redefined in the
> > jpg folder.
>
> that is a bug with libjpeg, not e17
>
Yep.
> > In ecore:
> > It seems ecore does not respect :--disable-ecore-evas-sdl
> > --disable-ecore-sdl and still links to SDL if it exist, can someone
> > please test this under linux.
>
> there is no --disable-ecore-sdl option ... maybe that is why it doesnt work
> for you ;)
>
It didn't work on my test machine and i wanted some feedback from
other users as i do not have a linux machine to test it.
> > In edje:
> > edje_data.c: In function `_edje_edd_setup':
> > edje_data.c:70: warning: assignment from incompatible pointer type
> > edje_data.c:72: warning: assignment from incompatible pointer type
> > edje_data.c:73: warning: assignment from incompatible pointer type
> > edje_data.c:74: warning: assignment from incompatible pointer type
> > edje_data.c:75: warning: assignment from incompatible pointer type
> > edje_data.c:76: warning: assignment from incompatible pointer type
> > edje_data.c:77: warning: assignment from incompatible pointer type
> > edje_data.c:78: warning: assignment from incompatible pointer type
>
> looks like simple prototype desyncs ... should be fixed, but shouldnt be a
> serious problem
>
It is not.
> > In E:
> > --- src/bin/Makefile.am.orig Fri Nov 9 16:20:53 2007
> > +++ src/bin/Makefile.am Fri Nov 9 16:21:15 2007
> > @@ -345,7 +345,7 @@ e_xinerama.c
> >
> > enlightenment_init_LDFLAGS = @e_libs@
> >
> > -setuid_root_mode = a=rx,u+xs
> > +setuid_root_mode = a=rx,u+x
> > install-exec-hook:
> > @chmod $(setuid_root_mode)
> > $(DESTDIR)$(bindir)/enlightenment_sys$(EXEEXT) || true
>
> clearly this is not correct.
>
In the port system we do not install anything with setuid root. If the
user wants it then the user has to manually update it.
> > --- src/bin/e_fm.c.orig Wed Nov 7 11:45:43 2007
> > +++ src/bin/e_fm.c Fri Dec 7 15:44:09 2007
> > @@ -104,7 +104,7 @@ struct _E_Fm2_Smart_Data
> > E_Drop_Handler *drop_handler;
> > E_Fm2_Icon *drop_icon;
> > E_Fm2_Mount *mount;
> > - char drop_after;
> > + signed char drop_after;
> > unsigned char drop_show : 1;
> > unsigned char drop_in_show : 1;
> > unsigned char drop_all : 1;
>
> either everything should be "char" or not ... inserting "signed" here without
> an explanation as to why doesnt seem like a good idea.
>
This fixes macppc.
> > @@ -3214,7 +3214,7 @@ _e_fm2_uri_parse(const char *val)
> > p = val + 7;
> > if (*p != '/')
> > {
> > - for (i = 0; *p != '/' && *p != '\0' && i <
> > _POSIX_HOST_NAME_MAX; p++, i++)
> > + for (i = 0; *p != '/' && *p != '\0' && i < MAXHOSTNAMELEN; p++,
> > i++) hostname[i] = *p;
> > }
> > hostname[i] = '\0';
> > @@ -3247,9 +3247,9 @@ _e_fm2_uri_path_list_get(Evas_List *uri_list)
> > {
> > E_Fm2_Uri *uri;
> > Evas_List *l, *path_list = NULL;
> > - char current_hostname[_POSIX_HOST_NAME_MAX];
> > + char current_hostname[MAXHOSTNAMELEN];
>
> move this to autotools as a build time test as this ugly churn of defines will
> simply break some systems while "fixing" others.
>
> > - if (gethostname(current_hostname, _POSIX_HOST_NAME_MAX) == -1)
> > + if (gethostname(current_hostname, MAXHOSTNAMELEN) == -1)
>
> sizeof(current_hostname) should be used instead
>
>
Again i am not pushing these patches. This is OpenBSD specific.
> > --- src/bin/e_main.c.orig Mon Dec 3 13:59:16 2007
> > +++ src/bin/e_main.c Mon Dec 3 13:59:48 2007
> > @@ -1088,13 +1088,13 @@ _e_main_dirs_init(void)
> > {
> > snprintf(buf, sizeof(buf),
> > "gzip -d -c < %s/data/other/desktop_files.tar.gz | "
> > - "(cd %s/applications/ ; tar -xkf -)",
> > + "(cd %s/applications/ ; /bin/pax -rk)",
> > e_prefix_data_get(),
> > efreet_data_home_get());
> > system(buf);
> > snprintf(buf, sizeof(buf),
> > "gzip -d -c < %s/data/other/desktop_order.tar.gz | "
> > - "(cd %s/.e/e/ ; tar -xkf -)",
> > + "(cd %s/.e/e/ ; /bin/pax -rk)",
> > e_prefix_data_get(),
> > homedir);
> > system(buf);
> > @@ -1105,7 +1105,7 @@ _e_main_dirs_init(void)
> > {
> > snprintf(buf, sizeof(buf),
> > "gzip -d -c < %s/data/other/efm_favorites.tar.gz | "
> > - "(cd %s/.e/e/ ; tar -xkf -)",
> > + "(cd %s/.e/e/ ; /bin/pax -rk)",
> > e_prefix_data_get(),
> > homedir);
> > system(buf);
>
> ugh, you gotta be kidding
>
Not really the "-k" is a GNU tar specific switch. It is not present on
the bsd tar. pax has the correct options.
> > --- src/modules/cpufreq/Makefile.am.orig Fri Nov 9 15:16:55 2007
> > +++ src/modules/cpufreq/Makefile.am Fri Nov 9 15:17:26 2007
> > @@ -28,7 +28,7 @@ freqsetdir = $(pkgdir)
> > freqset_DATA = \
> > freqset$(EXEEXT)
> >
> > -setuid_root_mode = a=rx,u+xs
> > +setuid_root_mode = a=rx,u+x
> > install-data-hook:
> > @chmod $(setuid_root_mode)
> > $(DESTDIR)$(freqsetdir)/freqset$(EXEEXT) || true
>
> again, obviously not correct
Again this removes the suid bit. As mentioned before this is only to
be able to integrate e into the port system.
On a side note cpufreq, temp and battery modules are disabled by
default as they use linux and freebsd specific call, fixing them is on
my todo list.
> -mike
>
Kind regards, Laurent.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
