On Sun, Apr 13, 2008 at 2:47 PM, Lars Munch <[EMAIL PROTECTED]> wrote:
> On Sun, Apr 13, 2008 at 01:03:35PM -0300, Gustavo Sverzut Barbieri wrote:

>  >   2) part_*() does not operate on the given part_id:
>  >
>  > +static Embryo_Cell
>  > +_edje_embryo_fn_part_raise(Embryo_Program *ep, Embryo_Cell *params)
>  > +{
>  > +   int part_id = 0;
>  >
>  > no initialization should be done here.
>  >
>  > +   ed = embryo_program_data_get(ep);
>  > +
>  > +   evas_object_raise(ed->obj);
>  >
>  > where do you use part_id? no where. Maybe you tried to base your code
>  > on other calls that get part_id and they use just like that. But
>  > notice that they use "edje_object_*()" functions, that get an Edje
>  > object and a part name, so they use part_id to get a rp->part->name.
>  > Since the function you want have no edje_object_*() equivalent, then
>  > you must get the object itself. And not having the
>  > edje_object_part_raise() or edje_object_part_lower() is what make me
>  > wonder if this would break things or not. If they won't break things,
>  > then we should add these and use them from embryo.
>
>  Yes, it might break things. I just found this comment in the docs for
>  edje_object_part_object_get() "You should never modify the state of the
>  returned object (with evas_object_move() or evas_object_hide() for
>  example)". I will dig a little deaper and see what I can find.

Yes.

Maybe it will not impact things. The problem with these calls is that
they would collide with Edje internal states, getting these
inconsistent. But since Edje does not handle any layer/stack-related
information in their states, maybe this is no problem, in this case
just add the call to edje C api (edje_object_part_{raise,lower}()) and
expose it from embryo.


-- 
Gustavo Sverzut Barbieri
http://profusion.mobi
Embedded Systems
--------------------------------------
MSN: [EMAIL PROTECTED]
Skype: gsbarbieri
Mobile: +55 (81) 9927 0010

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to