On Tue, Oct 7, 2008 at 12:10 PM, Mathieu Taillefumier <[EMAIL PROTECTED]> wrote: > this is a nice work. I compiled the lib on x86_64 bits system and i pass > without problems. I attached the various information and warning in the > error file. You will also find the results of the implemented tests (log > file).
Thanks for the report. eina_print_warning is a dead code, so I just removed it and most warning should be gone now. > eina_hash.c: In function 'eina_hash_del': > eina_hash.c:820: warning: 'hash_num' may be used uninitialized in this > function This warning is a false positive as the code should never execute the code using hash_num if it's uninitialized. And I don't want to hide this warning as if this goes wrong somewhere valgrind will be able to tell me what is going on. > eina_array.c: In function 'eina_array_remove': > eina_array.c:404: warning: 'data' may be used uninitialized in this function In fact it's also a false positive as we should have leave the function before reaching this point if data is not initialized. > eina_rbtree.c: In function 'eina_rbtree_inline_insert': > eina_rbtree.c:248: warning: 'last' may be used uninitialized in this > function This one is also a false positive, but it's really harder to understand, as it relly on red black tree property. In fact q and p could never be red and last not initialized, because when p == NULL, p must be considered as a black node. So during the first loop, their will be no test on last, but it will be setted and further used correctly. > eina_ememoa_fixed.c: In function 'eina_ememoa_fixed_statistics': > eina_ememoa_fixed.c:77: warning: unused variable 'efm' > eina_ememoa_unknown.c: In function 'eina_ememoa_unknown_size_statistics': > eina_ememoa_unknown.c:78: warning: unused variable 'efm' That's because of ememoa macro that doesn't use its parameters when debug is desactivated. Something that should be fixed in ememoa indeed. > Running suite(s): Eina > [eina_test_error.c:71] eina_error_macro() An error > [eina_test_error.c:72] eina_error_macro() An info > [eina_test_error.c:73] eina_error_macro() A warning > [eina_test_error.c:74] eina_error_macro() A debug > [31;1m[eina_test_magic.c:69] eina_magic_simple() [0m*** Eina Magic Check > Failed !!! > Input handle pointer is NULL ! > *** NAUGHTY PROGRAMMER!!! > *** SPANK SPANK SPANK!!! > *** Now go fix your code. Tut tut tut! > > [31;1m[eina_test_magic.c:78] eina_magic_simple() [0m*** Eina Magic Check > Failed !!! > Input handle has already been freed! > *** NAUGHTY PROGRAMMER!!! > *** SPANK SPANK SPANK!!! > *** Now go fix your code. Tut tut tut! > > [31;1m[eina_test_magic.c:81] eina_magic_simple() [0m*** Eina Magic Check > Failed !!! > Input handle is wrong type > Expected: 7781fee7 - Eina Magic Test > Supplied: 028757b2 - (null) > *** NAUGHTY PROGRAMMER!!! > *** SPANK SPANK SPANK!!! > *** Now go fix your code. Tut tut tut! This are the result of checking the error subsystem, and every thing seems to be ok. > # specimen experiment time starting time ending time > 100000 5635989 140939 5776928 > 200000 14216360 5778156 19994516 > Run specimens_check: 1000 > 100%: Checks: 51, Failures: 0, Errors: 0 So far so good. Thanks for reporting all of this. Between what compiler are you using ? -- Cedric BAIL ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
