On Sun, Dec 14, 2008 at 1:16 PM, Viktor Kojouharov <vkojouha...@gmail.com> wrote: > On Sun, 2008-12-14 at 12:56 -0200, Gustavo Sverzut Barbieri wrote: >> On Sun, Dec 14, 2008 at 12:24 PM, Sebastian Dransfeld >> <sebas...@tango.flipp.net> wrote: >> > Viktor Kojouharov wrote: >> >> Hi, >> >> >> >> I'm trying to bring epsilon into the 21st century with some >> >> eina_stringshare love. The attached patch should convert all epsilon >> >> strings to consts that use eina_stringshare_*. Please review it. >> > >> > Strings which are probably unique (like paths) should not be >> > stringshared, not need to stringshare something that wont be shared. >> >> hum, that's very true. I just reviewed code from a local pov, but in a >> global/application pov doing blind stringshare is bad, it will add >> more strings to the pool and make it slower to search for strings and >> even add other possibly more useful strings (although cedric did some >> optimizations to make it fast even for lots of strings). >> >> good ways to find out if string is shared: >> - if it is used in other places of your code, that's maybe the most >> obvious/easiest; >> - if it goes to evas: it will stringshare; >> - if it goes to edje, same as evas, since it will probably send to >> evas anyway. >> >> thanks sebastian for pointing it out! > > in the context of epsilon, wouldn't the path be very likely to be used > in multiple places? For instance, if multiple users (e_fm, a > filechooser, something else) request the same path to be thumbnailed, > wouldn't it make sense to share it?
need to evaluate it, this usually do not live long, as it is a request -> do -> report -> free cycle, and often we share with the "do", but it's in another process (the real thumbnailer). -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
