On Sun, 14 Dec 2008 15:24:06 +0100 Sebastian Dransfeld <sebas...@tango.flipp.net> babbled:
> Viktor Kojouharov wrote: > > Hi, > > > > I'm trying to bring epsilon into the 21st century with some > > eina_stringshare love. The attached patch should convert all epsilon > > strings to consts that use eina_stringshare_*. Please review it. > > Strings which are probably unique (like paths) should not be > stringshared, not need to stringshare something that wont be shared. they probably should be shared. this is one of the big reasons for stringshare. why? 1. paths are often long (40-100 or more chars) 2. there ARE multiple copies. eg: one in the RGBA software engine one in the evas image object one in the "wrapper" smart objects or structs and now multiple instances of that same icon/image on screen at once... ... and possibly others so the string is really duplicated a lot and stringshare helps. a lot. i highly recommend putting paths to files in strignshare. highly. it was actually analysis of all these duplicated file paths for images/icons that first gave birth to stringshare. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel