On Mon, 19 Jan 2009, Gustavo Sverzut Barbieri wrote:

>> about that bug, i think that the problem is that, line 191, we try to free
>> l->data while l is not available anymore.
>>
>> so maybe we can switch the lines 190 et 191 : free first l->data, then
>> remove the list item l.
>>
>> what do you think ?
>
> it is still wrong since l->next will be accessed right after that. You
> need to move E_FREE() call before list removal and use proper
> iteration, might be good use of my EINA_LIST_FOREACH_SAFE().

I've already comitted it. I add a FIXME to say that it's not the correct 
fix. I don't know how to use EINA_LIST_FOREACH_SAFE().

Vincent

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to