On Mon, May 18, 2009 at 7:13 PM, Viktor Kojouharov <vkojouha...@gmail.com> wrote: > On Mon, 2009-05-18 at 18:30 -0300, Rafael Antognolli wrote: >> On Mon, May 18, 2009 at 7:46 AM, Gustavo Sverzut Barbieri >> <barbi...@profusion.mobi> wrote: >> > On Mon, May 18, 2009 at 6:31 AM, Ryan Raasch <ryan.raa...@gmail.com> wrote: >> >> Hello, >> >> >> >> I am trying to write an EThumb_Plugin to load an xml file with an >> >> embbeded jpeg file. However, the plugins written for Ethumb need >> >> "ethumb_private.h". This is not very practical to develop plugins >> >> outside of the source tree. >> >> >> >> Is there any thoughts on this? I will help if needed. >> > >> > yeah, Ethumb struct could be moved to Ethumb_Plugin or even better: >> > the attributes we need could have setters in Ethumb.h or >> > Ethumb_Plugin.h, most are already in Ethumb.h, now just need couple to >> > access canvas and all, then move plugins to use it instead. >> >> I've just added some getters to Ethumb API. I think they are enough >> (at least to my plugins), but let me know if you need any other. > > > maybe this is the right thread to brings this up: > > could be a good idea to have a some sort of generic getter/setter that > sets properties for plugins to look at. Instead of having > ethumb_video_time_get|set, and the document page equivalent, it would be > better to have ethumb_property_get|set or something of that sort, so > that plugins can be able to obtain other properties that could be > useful, without adding more setters and getters. This would also make > the video_time and document_page functions obsolete.
I agree. I only have made these video_time and document_page functions because it was simpler than having a generic property get/set function, and since I was not planning to write newer plugins soon, it wasn't really necessary. But maybe it's time to do it now. I'll take a look at it soon, just finishing the client/server stuff and some changes on ethumb lib itself. -- Rafael Antognolli ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
