Hello, All. In message from 19 june 2009 Gustavo Sverzut Barbieri wrote:
> > gadgets it call 'is_site(NULL)', so this case should be properly matched > > in gadget module. > > Ok, in order to avoid adding overhead document that is_site() will get > a stringshared string and you pre-stringshare the known names as you > listed below. Before calling is_site() you certify that the parameter > is stringshared already or do that once. Then functions can just check > for pointers being equal and avoid strcmp(). In that case, if we avoiding strcmp, maybe let's use integer id for site? Make enums with two ranges: mandatory and user. And then we simple check id's. > Last but not least, since we have common stuff here, provide the > following functions by default: > - PREFIX_only_shelf_is_site() > - PREFIX_only_desktop_is_site() > - PREFIX_only_efm_toolbar_is_site() > - PREFIX_not_efm_toolbar_is_site() Right, I'll do this helpers. > > There are several site names exists now: > > -- 'shelf' - all shelfs, > > -- 'toolbar' - the toolbar used in EFM2, > > name this "fileman" or something else, otherwise if we wish to have > other toolbar categories it will conflict. I have examined code and seen that e_toolbar with gadcons used only in efm. In all other cases used toolbar from e_widget_toolbar.c and it can't have gadcons. Right? > e/src/modules: [...skip...] > - winselector: !toolbar > - wlan: all Thanks! Sincerely yours, Sergey. -- Jabber/XMPP: [email protected] Cellular: +7-909-206-5992 ------------------------------------------------------------------------------ Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250. Need another reason to go? 24-hour hacker lounge. Register today! http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
