On Thu, Mar 11, 2010 at 10:52 AM, michael bouchaud <michael.bouch...@gmail.com> wrote: > Hi, everybody > I have the need to switch the e17 desk externally, in my current project. > So I have added a dbus signal to do this. What do you think about this. > The desk can be descibed by here name or position. > > and it will be great for me if this go in svn :).
Ok, I did something similar instead of your patch, it is in r47168. Please consider the following when doing more patches: - these changes should go into src/modules/msgbus module, not in src/bin/e_msgbus.c, these are restricted to the minimum required to manage E17 (load modules, restart...) - do not overload calls with parameters. Do one for name, another for position (and position is bi-dimensional in this case) - check if the interface already exist in src/modules/msgbus before exposing a new one. - respect indentation and coding style, where braces go, etc -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
