On Mon, Mar 15, 2010 at 6:51 AM, michael bouchaud <[email protected]> wrote: > 2010/3/12 Gustavo Sverzut Barbieri <[email protected]> >> >> On Thu, Mar 11, 2010 at 10:52 AM, michael bouchaud >> <[email protected]> wrote: >> > Hi, everybody >> > I have the need to switch the e17 desk externally, in my current >> > project. >> > So I have added a dbus signal to do this. What do you think about this. >> > The desk can be descibed by here name or position. >> > >> > and it will be great for me if this go in svn :). >> >> Ok, I did something similar instead of your patch, it is in r47168. > > Thanks very much !!!! >> >> Please consider the following when doing more patches: >> >> - these changes should go into src/modules/msgbus module, not in >> src/bin/e_msgbus.c, these are restricted to the minimum required to >> manage E17 (load modules, restart...) > > > Sorry I have missed this modules, but now ok ! >> >> - do not overload calls with parameters. Do one for name, another >> for position (and position is bi-dimensional in this case) > > It's why I have post this patch with 'What do you think about it'. :) I have > the response. > I remember, don't overload call.
:-) >> - check if the interface already exist in src/modules/msgbus before >> exposing a new one. > > I have missed the module so ... :) ok, no problem... it is a new module. >> - respect indentation and coding style, where braces go, etc > > Sorry I have forget to reindent :(. Next time this point will be clean. (I > expect) try to find out a indentation schema so you don't need to fix later. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: [email protected] Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
