On Wednesday, 04 August 2010, at 22:37:21 (+0200), Kim Woelders wrote: > I don't think there will be portability issues with this patch > unless you somehow get non-matching old Xlib/Xmu versions - not very > likely I'd say. > If I were in a cleaning mood I'd get rid of Xmu, which as far as I > can see only is used for > XA_TEXT/COMPOUND_TEXT/XA_UTF8_STRING(Xdisplay), which could easily > be replaced with some new props[...].
Can you elaborate on this idea? > The availability of XUTF8StringStyle can be tested with > X_HAVE_UTF8_STRING. As for systems that don't have > XmbTextListToTextProperty ... i.e. pre-X11R5 ~ 1991 ... hmm.. do we > care? I don't care if they lack XmbTextListToTextProperty(), no. But I would like to support X11R6 versions which didn't have XUTF8StringStyle since commercial UNIXes, AFAIK, haven't all caught up with modern Xorg.... > A few comments... > > The "else if (rq->target == XA_STRING)" case is redundant - same as final > "else" case. You're right. > I think that in both cases where XmbTextListToTextProperty() is called > XFree(xtextp.value) should be added after XChangeProperty(). Right again. Wow, that would be one heck of a resource leak.... Kim/Paolo, please comment on the patch I committed. Most importantly, if/how to condense or eliminate the two XmbText...() cases. Thanks! Michael -- Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <m...@kainx.org> Linux Server/Cluster Admin, LBL.gov Author, Eterm (www.eterm.org) ----------------------------------------------------------------------- "To touch the rose unfearful is to meet the thorn and pierce the heart's emotion and feel the emptiness no more." -- Jars of Clay, "No One Loves Me Like You" ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
