Hello Thomas,
at the moment I don't have access to an external monitor for further
debugging of the randr mode setting issue. Last time I had access to
an external monitor, I traced it down to a wrong events sent by my
driver for some reason.
It looks like your driver doesn't send mode names. Attached patch
fixes their freeing.
BR,
Leif
P.S.: Further patches for RandR follow as soon, as I have access to an
external monitor again.
2010/10/20 Thomas Sachau <[email protected]>:
> The first one only occured once, seems to be evas related and i cannot easily
> reproduce it.
>
> The second one is randr related and i can reproduce it in a good amount of
> cases, usually when i
> start an older game in wine in fullscreen mode, where the aspect ration gets
> adjusted by the nvidia
> drivers (a 4:3 fullscreen doesnt look that well on a 16:9 screen). If e17
> does not crash during that
> game, i can exit the game without problems. But once i try to exit e17, i get
> the second bt, which
> results in e17 not reacting to any input (requires a kill -9 to stop it).
>
>
> --
> Thomas Sachau
>
> Gentoo Linux Developer
>
>
> ------------------------------------------------------------------------------
> Nokia and AT&T present the 2010 Calling All Innovators-North America contest
> Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
> $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
> Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
> http://p.sf.net/sfu/nokia-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
diff --git a/ecore/src/lib/ecore_x/xlib/ecore_x_randr_12.c b/ecore/src/lib/ecore_x/xlib/ecore_x_randr_12.c
index bd56228..bc9cdd3 100644
--- a/ecore/src/lib/ecore_x/xlib/ecore_x_randr_12.c
+++ b/ecore/src/lib/ecore_x/xlib/ecore_x_randr_12.c
@@ -405,13 +405,14 @@ ecore_x_randr_mode_info_get(Ecore_X_Window root, Ecore_X_Randr_Mode mode)
ret->vSyncEnd = res->modes[i].vSyncEnd;
ret->vTotal = res->modes[i].vTotal;
ret->name = NULL;
- ret->nameLength = 0;
if (res->modes[i].nameLength > 0)
{
ret->nameLength = res->modes[i].nameLength;
ret->name = strndup(res->modes[i].name,
res->modes[i].nameLength);
}
+ else
+ ret->nameLength = 0;
ret->modeFlags = res->modes[i].modeFlags;
break;
}
@@ -438,7 +439,7 @@ ecore_x_randr_mode_info_free(Ecore_X_Randr_Mode_Info *mode_info)
if (!mode_info)
return;
- if (mode_info->name)
+ if (mode_info->nameLength > 0)
free(mode_info->name);
free(mode_info);
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
