Tom,
I found my mistake in code that you apply in svn.
I should have remove "const " in elementary.
I send patch for fixing it.
On Sun, Feb 27, 2011 at 7:26 PM, Tom Hacohen <
tom.haco...@partner.samsung.com> wrote:
> Dear Jihoon,
>
> Again, thank you very much for your patch. You forgot adding
> "@since 1.1.0" to the edje docs but I added it for you cause I felt bad
> for not noticing it the first time you sent the patches :)
>
> Anyhow, in SVN.
>
> Thanks a lot for doing it,
> Tom.
>
>
>
>
> On Fri, 2011-02-25 at 20:40 +0900, Jihoon Kim wrote:
> > Hi, Tom.
> > Thank you for your quick review.
> > It's mistake by copy & paste :(
> > I send the patch again after fixing the problem.
> > Please review again.
> >
> > From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf Of Tom
> Hacohen
> > Sent: Friday, February 25, 2011 6:06 PM
> > To: Jihoon Kim
> > Cc: enlightenment-devel@lists.sourceforge.net; wh0705.ju
> > n...@samsung.com
> > Subject: Re: [E-devel] [PATCH] Add elm_entry_cursor_pos_{set, get} API
> >
> > Hey Jihoon,
> >
> > I didn't really went through the patch yet (I'm here for 2 seconds and
> then
> > I'm off, maybe I'll have time later)
> > but I noticed one issue:
> > edje_object_part_text_cursor_pos_set(const Evas_Object *obj, const char
> > *part, Edje_Cursor cur, int pos)
> > obj shouldn't be const in set. It's probably the same in other places.
> > Please take a look at that.
> > I'll try to review it better ASAP.
> >
> > --
> > Tom.
> > On Fri, Feb 25, 2011 at 8:52 AM, Jihoon Kim <jihoon48....@samsung.com>
> > wrote:
> > Hello,
> >
> > There has been no way to set or get the cursor position of entry in the
> > elementary.
> > In this patch includes elm_entry_cursor_pos_set/get and
> > elm_scrolled_entry_cursor_pos_set/get APIs.
> >
> > Would you please review thist patch?
> >
> >
> >
> ----------------------------------------------------------------------------
> > --
> > Free Software Download: Index, Search & Analyze Logs and other IT data in
> > Real-Time with Splunk. Collect, index and harness all the fast moving IT
> > data
> > generated by your applications, servers and devices whether physical,
> > virtual
> > or in the cloud. Deliver compliance at lower cost and gain new business
> > insights. http://p.sf.net/sfu/splunk-dev2dev
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
> >
> >
> >
> ------------------------------------------------------------------------------
> > Free Software Download: Index, Search & Analyze Logs and other IT data in
> > Real-Time with Splunk. Collect, index and harness all the fast moving IT
> data
> > generated by your applications, servers and devices whether physical,
> virtual
> > or in the cloud. Deliver compliance at lower cost and gain new business
> > insights. http://p.sf.net/sfu/splunk-dev2dev
> > _______________________________________________ enlightenment-devel
> mailing list enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Free Software Download: Index, Search & Analyze Logs and other IT data in
> Real-Time with Splunk. Collect, index and harness all the fast moving IT
> data
> generated by your applications, servers and devices whether physical,
> virtual
> or in the cloud. Deliver compliance at lower cost and gain new business
> insights. http://p.sf.net/sfu/splunk-dev2dev
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
Index: src/lib/elm_entry.c
===================================================================
--- src/lib/elm_entry.c (revision 57372)
+++ src/lib/elm_entry.c (working copy)
@@ -2220,7 +2220,7 @@ elm_entry_cursor_content_get(const Evas_Object *ob
* @ingroup Entry
*/
EAPI void
-elm_entry_cursor_pos_set(const Evas_Object *obj, int pos)
+elm_entry_cursor_pos_set(Evas_Object *obj, int pos)
{
ELM_CHECK_WIDTYPE(obj, widtype);
Widget_Data *wd = elm_widget_data_get(obj);
Index: src/lib/elc_scrolled_entry.c
===================================================================
--- src/lib/elc_scrolled_entry.c (revision 57372)
+++ src/lib/elc_scrolled_entry.c (working copy)
@@ -1159,7 +1159,7 @@ elm_scrolled_entry_cursor_content_get(const Evas_O
* @ingroup Scrolled_Entry
*/
EAPI void
-elm_scrolled_entry_cursor_pos_set(const Evas_Object *obj, int pos)
+elm_scrolled_entry_cursor_pos_set(Evas_Object *obj, int pos)
{
ELM_CHECK_WIDTYPE(obj, widtype);
Widget_Data *wd = elm_widget_data_get(obj);
Index: src/lib/Elementary.h.in
===================================================================
--- src/lib/Elementary.h.in (revision 57372)
+++ src/lib/Elementary.h.in (working copy)
@@ -1224,7 +1224,7 @@ extern "C" {
EAPI Eina_Bool elm_entry_cursor_is_visible_format_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
EAPI const char *elm_entry_cursor_content_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
EAPI Eina_Bool elm_entry_cursor_geometry_get(const Evas_Object *obj, Evas_Coord *x, Evas_Coord *y, Evas_Coord *w, Evas_Coord *h) EINA_ARG_NONNULL(1);
- EAPI void elm_entry_cursor_pos_set(const Evas_Object *obj, int pos) EINA_ARG_NONNULL(1);
+ EAPI void elm_entry_cursor_pos_set(Evas_Object *obj, int pos) EINA_ARG_NONNULL(1);
EAPI int elm_entry_cursor_pos_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
EAPI void elm_entry_selection_cut(Evas_Object *obj) EINA_ARG_NONNULL(1);
EAPI void elm_entry_selection_copy(Evas_Object *obj) EINA_ARG_NONNULL(1);
@@ -2244,7 +2244,7 @@ extern "C" {
EAPI Eina_Bool elm_scrolled_entry_cursor_is_format_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
EAPI Eina_Bool elm_scrolled_entry_cursor_is_visible_format_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
EAPI const char *elm_scrolled_entry_cursor_content_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
- EAPI void elm_scrolled_entry_cursor_pos_set(const Evas_Object *obj, int pos) EINA_ARG_NONNULL(1);
+ EAPI void elm_scrolled_entry_cursor_pos_set(Evas_Object *obj, int pos) EINA_ARG_NONNULL(1);
EAPI int elm_scrolled_entry_cursor_pos_get(const Evas_Object *obj) EINA_ARG_NONNULL(1);
EAPI void elm_scrolled_entry_selection_cut(Evas_Object *obj) EINA_ARG_NONNULL(1);
EAPI void elm_scrolled_entry_selection_copy(Evas_Object *obj) EINA_ARG_NONNULL(1);
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
