Haha, unlucky me. I checked the edje patch to make sure you fixed all the consts and when I saw it ok, didn't even look at it in the elm patch.
My bad, thanks, in svn. -- Tom. On Sun, 2011-02-27 at 20:27 +0900, Jihoon Kim wrote: > Tom, > I found my mistake in code that you apply in svn. > I should have remove "const " in elementary. > I send patch for fixing it. > > On Sun, Feb 27, 2011 at 7:26 PM, Tom Hacohen > <tom.haco...@partner.samsung.com> wrote: > Dear Jihoon, > > Again, thank you very much for your patch. You forgot adding > "@since 1.1.0" to the edje docs but I added it for you cause I > felt bad > for not noticing it the first time you sent the patches :) > > Anyhow, in SVN. > > Thanks a lot for doing it, > Tom. > > > > > > On Fri, 2011-02-25 at 20:40 +0900, Jihoon Kim wrote: > > Hi, Tom. > > Thank you for your quick review. > > It's mistake by copy & paste :( > > I send the patch again after fixing the problem. > > Please review again. > > > > From: tta...@gmail.com [mailto:tta...@gmail.com] On Behalf > Of Tom Hacohen > > Sent: Friday, February 25, 2011 6:06 PM > > To: Jihoon Kim > > Cc: enlightenment-devel@lists.sourceforge.net; wh0705.ju > > n...@samsung.com > > Subject: Re: [E-devel] [PATCH] Add > elm_entry_cursor_pos_{set, get} API > > > > Hey Jihoon, > > > > I didn't really went through the patch yet (I'm here for 2 > seconds and then > > I'm off, maybe I'll have time later) > > but I noticed one issue: > > edje_object_part_text_cursor_pos_set(const Evas_Object *obj, > const char > > *part, Edje_Cursor cur, int pos) > > obj shouldn't be const in set. It's probably the same in > other places. > > Please take a look at that. > > I'll try to review it better ASAP. > > > > -- > > Tom. > > On Fri, Feb 25, 2011 at 8:52 AM, Jihoon Kim > <jihoon48....@samsung.com> > > wrote: > > Hello, > > > > There has been no way to set or get the cursor position of > entry in the > > elementary. > > In this patch includes elm_entry_cursor_pos_set/get and > > elm_scrolled_entry_cursor_pos_set/get APIs. > > > > Would you please review thist patch? > > > > > > > > ---------------------------------------------------------------------------- > > -- > > Free Software Download: Index, Search & Analyze Logs and > other IT data in > > Real-Time with Splunk. Collect, index and harness all the > fast moving IT > > data > > generated by your applications, servers and devices whether > physical, > > virtual > > or in the cloud. Deliver compliance at lower cost and gain > new business > > insights. http://p.sf.net/sfu/splunk-dev2dev > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > > > ------------------------------------------------------------------------------ > > Free Software Download: Index, Search & Analyze Logs and > other IT data in > > Real-Time with Splunk. Collect, index and harness all the > fast moving IT data > > generated by your applications, servers and devices whether > physical, virtual > > or in the cloud. Deliver compliance at lower cost and gain > new business > > insights. http://p.sf.net/sfu/splunk-dev2dev > > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > ------------------------------------------------------------------------------ > > Free Software Download: Index, Search & Analyze Logs and other > IT data in > Real-Time with Splunk. Collect, index and harness all the fast > moving IT data > generated by your applications, servers and devices whether > physical, virtual > or in the cloud. Deliver compliance at lower cost and gain new > business > insights. http://p.sf.net/sfu/splunk-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ Free Software Download: Index, Search & Analyze Logs and other IT data in Real-Time with Splunk. Collect, index and harness all the fast moving IT data generated by your applications, servers and devices whether physical, virtual or in the cloud. Deliver compliance at lower cost and gain new business insights. http://p.sf.net/sfu/splunk-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
