On 02/27/2011 12:09 PM, Enlightenment SVN wrote:
> Log:
> e17: startup: cancel cb. this needs to run just once

This is wrong. The returns ECORE_CALLBACK_PASS_ON and 
ECORE_CALLBACK_DONE are the only legit for a event return.

We should pass on the event, as others might also want it. We cancel the 
event handler by deleting it just afterwards.

S.

>
>
> Author:       jeffdameth
> Date:         2011-02-27 03:09:49 -0800 (Sun, 27 Feb 2011)
> New Revision: 57370
> Trac:         http://trac.enlightenment.org/e/changeset/57370
>
> Modified:
>    trunk/e/src/bin/e_startup.c
>
> Modified: trunk/e/src/bin/e_startup.c
> ===================================================================
> --- trunk/e/src/bin/e_startup.c       2011-02-27 10:34:55 UTC (rev 57369)
> +++ trunk/e/src/bin/e_startup.c       2011-02-27 11:09:49 UTC (rev 57370)
> @@ -64,7 +64,7 @@
>        }
>      e_exec(NULL, desktop, NULL, NULL, NULL);
>      snprintf(buf, sizeof(buf), "%s %s", _("Starting"), desktop->name);
> -   e_init_status_set(buf);
> +   e_init_status_set(buf);
>      ecore_job_add(_e_startup_next_cb, NULL);
>   }
>
> @@ -86,5 +86,5 @@
>         start_app_pos = 0;
>      free(buf);
>      _e_startup();
> -   return ECORE_CALLBACK_PASS_ON;
> +   return ECORE_CALLBACK_CANCEL;
>   }
>
>
> ------------------------------------------------------------------------------
> Free Software Download: Index, Search&  Analyze Logs and other IT data in
> Real-Time with Splunk. Collect, index and harness all the fast moving IT data
> generated by your applications, servers and devices whether physical, virtual
> or in the cloud. Deliver compliance at lower cost and gain new business
> insights. http://p.sf.net/sfu/splunk-dev2dev
> _______________________________________________
> enlightenment-svn mailing list
> enlightenment-...@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to