Hm... I remember seeing that annoying bug. Have you talked to guys in ooffice's dev channel? Might speed up things a little.
I don't think it's a good idea to start patching e in an application specific way, but if you like to do so maybe add a tag as e.g. 'WORKAROUND-BUG' in the commit message with a link to your filed bug so it's easy to be found an reverted once the bug is fixed. I had a similar case with randr stuff but had to inline it in the comments. Hard to find for others who don't know about it. Might be the time to extend the commit policies we have with such a tag so we can easily find code which was introduced to workaround malfunctioning code of other projects. BR, Leif 2011/3/9 [email protected] <[email protected]>: > On Wed, Mar 9, 2011 at 1:59 AM, Leif Middelschulte > <[email protected]> wrote: >> Hey, >> >> just curious: Shouldn't ooffice be fixed instead of introducing exceptions >> in e? >> > Yes, I will file a bug for it. problem is it can take a few years > until it may be fixed upstream from my experience with projects like > these. the current behavior from pointer warp was quite disturbing, > i.e it does not let the mouse get outside of the ooffice dialog when > the main window is around with jumping pointer back and forth. It's > really that ooffice does things plain wrong. instead of setting the > dialogs to be modal they send an activate event for the dialog after > the main window accepted its focus in event. anyway i'll revert this > patch tomorrow with a more specific handling of this case. > > >> BR, >> >> Leif >> >> 2011/3/9 Enlightenment SVN <[email protected]>: >>> Log: >>> e17: disable pointer warp on _net_active_window client message >>> >>> >>> Author: jeffdameth >>> Date: 2011-03-08 15:09:09 -0800 (Tue, 08 Mar 2011) >>> New Revision: 57608 >>> Trac: http://trac.enlightenment.org/e/changeset/57608 >>> >>> Modified: >>> trunk/e/src/bin/e_manager.c >>> >>> Modified: trunk/e/src/bin/e_manager.c >>> =================================================================== >>> --- trunk/e/src/bin/e_manager.c 2011-03-08 22:35:11 UTC (rev 57607) >>> +++ trunk/e/src/bin/e_manager.c 2011-03-08 23:09:09 UTC (rev 57608) >>> @@ -969,8 +969,15 @@ >>> if (!bd->lock_user_stacking) e_border_raise(bd); >>> if (!bd->lock_focus_out) >>> { >>> - if (e_config->focus_policy != E_FOCUS_CLICK) >>> - ecore_x_pointer_warp(bd->zone->container->win, >>> + int requestor_id = e->data.l[2]; >>> + /* FIXME for now only set pointer when not >>> + requested by a client. ooffice does send this >>> + request for dialogs which should be modal when >>> + the main window gets focus. causing the pointer >>> + to jump back and forth. are there any other >>> + apps that use _net_active_window ? */ >>> + if ((requestor_id == 2) && (e_config->focus_policy >>> != E_FOCUS_CLICK)) >>> + ecore_x_pointer_warp(bd->zone->container->win, >>> bd->x + (bd->w / 2), bd->y + >>> (bd->h / 2)); >>> e_border_focus_set(bd, 1, 1); >>> } >>> >>> >>> ------------------------------------------------------------------------------ >>> What You Don't Know About Data Connectivity CAN Hurt You >>> This paper provides an overview of data connectivity, details >>> its effect on application quality, and explores various alternative >>> solutions. http://p.sf.net/sfu/progress-d2d >>> _______________________________________________ >>> enlightenment-svn mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn >>> >> >> ------------------------------------------------------------------------------ >> Colocation vs. Managed Hosting >> A question and answer guide to determining the best fit >> for your organization - today and in the future. >> http://p.sf.net/sfu/internap-sfd2d >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > ------------------------------------------------------------------------------ > Colocation vs. Managed Hosting > A question and answer guide to determining the best fit > for your organization - today and in the future. > http://p.sf.net/sfu/internap-sfd2d > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
