On Thu, 2 Jun 2011 12:48:42 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> said:
i missed them - reading just the first patch mail. i had my mailer in "show marked mails" mode and missed the rest of the thread :( > Btw, I reviewed this before. > http://www.mail-archive.com/enlightenment-devel@lists.sourceforge.net/msg32665.html > > But that's not considered. Any idea on that? > > > Daniel Juyung Seo (SeoZ) > > On Thu, Jun 2, 2011 at 12:44 PM, Daniel Juyung Seo <seojuyu...@gmail.com> > wrote: > > Great! Thanks raster and seunggyun :) > > > > Daniel Juyung Seo (SeoZ) > > > > On Thu, Jun 2, 2011 at 12:14 PM, Carsten Haitzler <ras...@rasterman.com> > > wrote: > >> On Fri, 20 May 2011 21:01:02 +0900 Seunggyun Kim <sgyun....@samsung.com> > >> said: > >> > >> hey seunggym! > >> > >> thanks for the patch. reviewed and in svn. > >> > >> just take note: > >> > >> when doing math inside if's put the math inside ()'s also other math ops > >> where you mix +, -, / and *. i fixed the patch for these bits. i.e. > >> > >> a + b / 2 <- WRONG > >> a + (b / 2) <- RIGHT > >> > >> if (a + b < 2) <- WRONG > >> if ((a + b) < 2) <- RIGHT > >> > >> why? i have seen too many peoilpe make "oops" errors in their math and > >> inside if's where they get the order of operation with +, -, /, * , other > >> bitwise and logic ops wrong. it's too much to keep in your head all the > >> time as to who gets done first, so just put ()'s in to explicitly say what > >> you want done in what order. it doesn't make the code slower and it > >> EXPLICITLY says to others reading your code what you intended to happen. > >> without this they are often left guessing when they hunt bugs in this > >> code. :) > >> > >>> Dear all, > >>> > >>> I introduce a new feature "reorder mode" of genlist. > >>> Using this feature, user can reoder genlist items dynamically. > >>> > >>> [API] > >>> ================================================================== > >>> - EAPI Eina_Bool elm_genlist_item_rename_mode_get(Elm_Genlist_Item *it) > >>> Get the rename mode state of an item. This gets the rename mode state of > >>> an item > >>> > >>> - EAPI void elm_genlist_reorder_mode_set(Evas_Object *obj, Eina_Bool > >>> reorder_mode) > >>> Set genlist reorder mode. This enables the item is moved to another item. > >>> ================================================================== > >>> > >>> After set this reorder api, if user press an item (long press), the item > >>> can be moved another position. > >>> Then if the user releases the item, the item will be reodered in genlist. > >>> When the user releases the holding item, > >>> Elm_Genlist_Item_Class.func.moved callback is also called. > >>> If needed, the application can add some logic in that callback function. > >>> > >>> Please review this patch. > >>> Thanks. > >>> > >> > >> > >> -- > >> ------------- Codito, ergo sum - "I code, therefore I am" -------------- > >> The Rasterman (Carsten Haitzler) ras...@rasterman.com > >> > >> > >> ------------------------------------------------------------------------------ > >> Simplify data backup and recovery for your virtual environment with > >> vRanger. Installation's a snap, and flexible recovery options mean your > >> data is safe, secure and there when you need it. Data protection magic? > >> Nope - It's vRanger. Get your free trial download today. > >> http://p.sf.net/sfu/quest-sfdev2dev > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
