On Tue, 2011-06-14 at 18:39 +0900, Carsten Haitzler wrote: > that function is called when the cnp atom type declared by the originator is > of > a type URI. you are relying on the other end to be "right" and always provide > a > uri. the code thats there aborts if its not a proper uri OR it cant just guess > it to be a full canonical path. so the code is being generous currently to > "bad > citizens" and letting their cnp data not match the type they say it'll match. > > now that cnp helper func is meant to add an image to the entry assuming the > thing being pasted is the uri (or path) TO an image file. the code hyoyoung is > proposing makes it a bit more lenient and in the case where it is neither a > full path nor a uri, will just insert the data as text. the user seers > something at least, just not an image. text instead. > > note this uri handling handles only local uri's (file://....) not remote ones. > it's possible the other party provides a remote uri (http:// or ftp:// or > something else elm wont handle). what do we do in this case? > > the fallback proposed would insert the url as text herere as opposed to "doing > nothing".
I criticized the reasoning more than anything else. The patch was described as a patch that fixes *Text* cnp, and for that, this patch is bad. We should fix the copy in elm to set the correct atoms (if not correct already). As for the wanted behavior, it really is a tough one, there are pros and cons for both. But even if we choose the "fallback to text" method, we should still implement it as a "text fallback" function that's called from all the other callbacks in a nice way, and not an "if" in the uri handling code... -- Tom. ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
