On Wed, 15 Jun 2011 15:02:09 +0900 Mike McCormack <mj.mccorm...@samsung.com> wrote:
> On 06/15/2011 12:36 AM, Carsten Haitzler (The Rasterman) wrote: > > > uncrustify solves all the formatting issues, we just need to apply it, but > > to apply it we need to have no pending work, patches or branches as it > > basically goes and edits pretty much every line of code. > > While having consistently formatted code is nice, I don't think using a tool > to automatically reformat all the code is worth it. I agree here. For very poorly formatted files, it's a great and quick fix which I use frequently. To apply it for everything will create issues, however, especially since ecrustify does not work perfectly for all cases. There are actually some (rare) areas where it will make the formatting considerably worse. > > It will break "blame" functionality of revision control and as you point out, > break any pending patches. > > If there's something really ugly, then maybe it's worth identifying and > fixing, but otherwise, fixing as you go is good. Commit hooks can be used > for pointing out the problem, but shouldn't block commits. > > thanks, > > Mike > > > ------------------------------------------------------------------------------ > EditLive Enterprise is the world's most technically advanced content > authoring tool. Experience the power of Track Changes, Inline Image > Editing and ensure content is compliant with Accessibility Checking. > http://p.sf.net/sfu/ephox-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Mike Blumenkrantz Zentific: Coding in binary since '10. ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
