On Wed, 22 Jun 2011, Rafael Antognolli wrote:
On Wed, Jun 22, 2011 at 7:16 PM, Vincent Torri <vto...@univ-evry.fr> wrote:
On Wed, 22 Jun 2011, Rafael Antognolli wrote:
On Wed, Jun 22, 2011 at 6:36 PM, Vincent Torri <vto...@univ-evry.fr>
wrote:
On Wed, 22 Jun 2011, Enlightenment SVN wrote:
Log:
evas/autotools - fix build when no dependencies for examples are found.
Some examples need ecore, ecore-evas and edje to demonstrate its
functionality. If --enable-build-examples is used, these dependencies
are
required. This commit disables the examples build if they are not found
in the system.
TODO: improve efl_examples.m4 and use it in evas build too - I'll work
on
that soon.
Author: antognolli
Date: 2011-06-22 14:31:53 -0700 (Wed, 22 Jun 2011)
New Revision: 60609
Trac: http://trac.enlightenment.org/e/changeset/60609
Modified:
trunk/evas/configure.ac
Modified: trunk/evas/configure.ac
===================================================================
--- trunk/evas/configure.ac 2011-06-22 20:54:32 UTC (rev 60608)
+++ trunk/evas/configure.ac 2011-06-22 21:31:53 UTC (rev 60609)
@@ -1576,9 +1576,10 @@
# put in here the dependencies for Evas' examples. they are
# meant to be 'real world' usage examples, thus one will be
# using higher level libraries on these programs
- PKG_CHECK_MODULES([ECORE_EVAS], [ecore-evas ecore])
+ PKG_CHECK_MODULES([ECORE_EVAS], [ecore-evas ecore], [],
[build_examples="no"])
PKG_CHECK_MODULES([EDJE], [edje],
- [edje_cc=$(pkg-config --variable=prefix edje)/bin/edje_cc])
+ [edje_cc=$(pkg-config --variable=prefix edje)/bin/edje_cc],
+ [build_examples="no"])
AC_SUBST(edje_cc)
else
build_examples="no"
wait, your are doing circular dep, here ?????? wtf ??? Put examples
outside the evas tree instead of doing that !
Hello Vincent! Please, don't blame me!
I know that they are circular dependencies, and that's bizarre. But if
I'm not wrong, Raster wants the examples inside the project trees
(raster, is that right?)
I discussed this with Gustavo (k-s) and the other guys that are
working on the documentation, and for now this was the best solution
we could have. It shouldn't break the normal build, even if someone
enables the examples build. But dist-check is broken now because of
missing files in EXTRA_DIST, I'll look at it soon.
Another possibility proposed by Gustavo was to have subprojects inside
the project tree, which would contain only the examples. These
subprojects could be built after all efl (or at least the core
libraries) were built already. And autotools also provides some means
to have subprojects inside a project.
I also agree that it's better to have the examples inside the project
tree (as a subproject or not), since it's easier to find them and you
can also reference them in the documentation.
What do you think about that?
we will have plenty of reports of people who will enable all the options
(like the gentoo guys) and who will complain about circular deps.
Well, just enabling examples build shouldn't break the build since the
check for ecore, ecore-evas and edje disables the examples if these
libraries are not found.
However, I don't know a good way to make a gentoo ebuild considering
these circular dependencies.
and if I'm not mistaken, we already have a...
http://trac.enlightenment.org/e/browser/trunk/EXAMPLES
Sure, but for example, if you look at the elementary examples, they
are more like real apps than very simple and specific examples. Inside
elementary/src/examples we are adding small specific examples for
every widget and/or group of functions. Please take a look at the
latest commits related to documentation.
About reference of the documentation, as doxygen accept html links, there is
no problem.
Sure, but then you don't have auto-generated pages listing all
available examples. And on every function you wouldn't have a list of
examples where that function is used. I think this increases the
chances of someone finding and understanding the examples.
that would be solved by the app below.
Vincent
what i would suggest is maybe a complete different project, that is focused
on examples and API, like devhelp (i've written something like that a few
years ago for the API):
http://trac.enlightenment.org/e/browser/trunk/DOCS/api/ecrin
it's certainly broken, right now (it is using ewl, iirc)
Well, that idea is nice, for sure, but how would you solve the problem
of examples and documentation getting out of sync with the current
code?
------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Data protection magic?
Nope - It's vRanger. Get your free trial download today.
http://p.sf.net/sfu/quest-sfdev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
