On Wed, Jun 22, 2011 at 7:45 PM, Vincent Torri <vto...@univ-evry.fr> wrote: > > > On Wed, 22 Jun 2011, Rafael Antognolli wrote: > >> On Wed, Jun 22, 2011 at 6:36 PM, Vincent Torri <vto...@univ-evry.fr> >> wrote: >>> >>> >>> On Wed, 22 Jun 2011, Enlightenment SVN wrote: >>> >>>> Log: >>>> evas/autotools - fix build when no dependencies for examples are found. >>>> >>>> Some examples need ecore, ecore-evas and edje to demonstrate its >>>> functionality. If --enable-build-examples is used, these dependencies >>>> are >>>> required. This commit disables the examples build if they are not found >>>> in the system. >>>> >>>> TODO: improve efl_examples.m4 and use it in evas build too - I'll work >>>> on >>>> that soon. >>>> >>>> >>>> >>>> Author: antognolli >>>> Date: 2011-06-22 14:31:53 -0700 (Wed, 22 Jun 2011) >>>> New Revision: 60609 >>>> Trac: http://trac.enlightenment.org/e/changeset/60609 >>>> >>>> Modified: >>>> trunk/evas/configure.ac >>>> >>>> Modified: trunk/evas/configure.ac >>>> =================================================================== >>>> --- trunk/evas/configure.ac 2011-06-22 20:54:32 UTC (rev 60608) >>>> +++ trunk/evas/configure.ac 2011-06-22 21:31:53 UTC (rev 60609) >>>> @@ -1576,9 +1576,10 @@ >>>> # put in here the dependencies for Evas' examples. they are >>>> # meant to be 'real world' usage examples, thus one will be >>>> # using higher level libraries on these programs >>>> - PKG_CHECK_MODULES([ECORE_EVAS], [ecore-evas ecore]) >>>> + PKG_CHECK_MODULES([ECORE_EVAS], [ecore-evas ecore], [], >>>> [build_examples="no"]) >>>> PKG_CHECK_MODULES([EDJE], [edje], >>>> - [edje_cc=$(pkg-config --variable=prefix edje)/bin/edje_cc]) >>>> + [edje_cc=$(pkg-config --variable=prefix edje)/bin/edje_cc], >>>> + [build_examples="no"]) >>>> AC_SUBST(edje_cc) >>>> else >>>> build_examples="no" >>> >>> wait, your are doing circular dep, here ?????? wtf ??? Put examples >>> outside the evas tree instead of doing that ! >> >> Hello Vincent! Please, don't blame me! >> >> I know that they are circular dependencies, and that's bizarre. > > it's not bizarre, it's just that i'm sure we'll have problems later. I'm > completely against circular dependencies
I completely agree on that. However, I tried to make the build system don't complain about it. Don't know yet if it's enough or not. > and why do you need to compile the tests ? Well, it's a poor check that the examples are buildable yet, and not outdated (otherwise the build would break). As I told you, I don't think that this is the best solution, it's just what we did for now. -- Rafael Antognolli ProFUSION embedded systems http://profusion.mobi ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
