Oh this mail was sent while I was writing it up :(
So again...
Dear all, I am going to fix genlist API.
And I feel like I need to announce this before I commit the code
because this will break some application's behavior.
[What?]
- Removal of elm_genlist_item_update() from elm_genlist_item_data_set() API.
[When?]
- Very soon. In a week?
[Description]
- Currently, elm_genlist_item_data_set() API calls
elm_genlist_item_update() API internally.
This causes unwanted realize of items. Some applications may need it
but others are not.
So I removed automatic item update from that API. If you want to
update item after setting data, you need to call
elm_genlist_item_update() API explicitly.
Thanks.
Daniel Juyung Seo (SeoZ)
Index: elm_genlist.c
===================================================================
--- elm_genlist.c (revision 61455)
+++ elm_genlist.c (working copy)
@@ -4777,9 +4777,9 @@ elm_genlist_item_del(Elm_Genlist_Item *it)
* Set the data item from the genlist item
*
* This set the data value passed on the elm_genlist_item_append() and
- * related item addition calls. This function will also call
- * elm_genlist_item_update() so the item will be updated to reflect the
- * new data.
+ * related item addition calls. This function will not call
+ * elm_genlist_item_update() anymore. So call elm_genlist_item_update()
+ * manually only when it's needed.
*
* @param it The item
* @param data The new data pointer to set
@@ -4792,7 +4792,6 @@ elm_genlist_item_data_set(Elm_Genlist_Item *it,
{
ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
elm_widget_item_data_set(it, data);
- elm_genlist_item_update(it);
}
On Mon, Jul 18, 2011 at 9:27 AM, Daniel Juyung Seo <[email protected]> wrote:
> Dear all, I am going to fix genlist API.
> And I feel like I need to announce this before I commit the code
> because this will break some application's behavior.
>
> [What to Change]
> I am going to remove elm_genlist_item_update() from
> elm_genlist_item_data_set() API soon.
>
> Currently, elm_genlist_item_data_set() API calls
> elm_genlist_item_update() API internally.
>
>
> Index: elm_genlist.c
> ===================================================================
> --- elm_genlist.c (revision 61455)
> +++ elm_genlist.c (working copy)
> @@ -4777,9 +4777,9 @@ elm_genlist_item_del(Elm_Genlist_Item *it)
> * Set the data item from the genlist item
> *
> * This set the data value passed on the elm_genlist_item_append() and
> - * related item addition calls. This function will also call
> - * elm_genlist_item_update() so the item will be updated to reflect the
> - * new data.
> + * related item addition calls. This function will not call
> + * elm_genlist_item_update() anymore. So call elm_genlist_item_update()
> + * manually only when it's needed.
> *
> * @param it The item
> * @param data The new data pointer to set
> @@ -4792,7 +4792,6 @@ elm_genlist_item_data_set(Elm_Genlist_Item *it,
> {
> ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
> elm_widget_item_data_set(it, data);
> - elm_genlist_item_update(it);
> }
>
------------------------------------------------------------------------------
AppSumo Presents a FREE Video for the SourceForge Community by Eric
Ries, the creator of the Lean Startup Methodology on "Lean Startup
Secrets Revealed." This video shows you how to validate your ideas,
optimize your ideas and identify your business strategy.
http://p.sf.net/sfu/appsumosfdev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
