This patch is committed.
Please refer this information if you use elm_genlist_item_data_set().
http://trac.enlightenment.org/e/changeset/61546
Daniel Juyung Seo (SeoZ)
On Thu, Jul 21, 2011 at 1:56 AM, Daniel Juyung Seo <seojuyu...@gmail.com> wrote:
> Dear all, I will commit this patch in 24 hours.
> So please be prepared if you're using elm_genlist_item_data_set() API.
> Thank you.
>
> Daniel Juyung Seo (SeoZ)
>
> On Mon, Jul 18, 2011 at 9:31 AM, Daniel Juyung Seo <seojuyu...@gmail.com>
> wrote:
>> Oh this mail was sent while I was writing it up :(
>> So again...
>>
>> Dear all, I am going to fix genlist API.
>> And I feel like I need to announce this before I commit the code
>> because this will break some application's behavior.
>>
>> [What?]
>> - Removal of elm_genlist_item_update() from elm_genlist_item_data_set()
>> API.
>>
>> [When?]
>> - Very soon. In a week?
>>
>> [Description]
>> - Currently, elm_genlist_item_data_set() API calls
>> elm_genlist_item_update() API internally.
>> This causes unwanted realize of items. Some applications may need it
>> but others are not.
>> So I removed automatic item update from that API. If you want to
>> update item after setting data, you need to call
>> elm_genlist_item_update() API explicitly.
>>
>> Thanks.
>> Daniel Juyung Seo (SeoZ)
>>
>>
>> Index: elm_genlist.c
>> ===================================================================
>> --- elm_genlist.c (revision 61455)
>> +++ elm_genlist.c (working copy)
>> @@ -4777,9 +4777,9 @@ elm_genlist_item_del(Elm_Genlist_Item *it)
>> * Set the data item from the genlist item
>> *
>> * This set the data value passed on the elm_genlist_item_append() and
>> - * related item addition calls. This function will also call
>> - * elm_genlist_item_update() so the item will be updated to reflect the
>> - * new data.
>> + * related item addition calls. This function will not call
>> + * elm_genlist_item_update() anymore. So call elm_genlist_item_update()
>> + * manually only when it's needed.
>> *
>> * @param it The item
>> * @param data The new data pointer to set
>> @@ -4792,7 +4792,6 @@ elm_genlist_item_data_set(Elm_Genlist_Item *it,
>> {
>> ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
>> elm_widget_item_data_set(it, data);
>> - elm_genlist_item_update(it);
>> }
>>
>>
>> On Mon, Jul 18, 2011 at 9:27 AM, Daniel Juyung Seo <seojuyu...@gmail.com>
>> wrote:
>>> Dear all, I am going to fix genlist API.
>>> And I feel like I need to announce this before I commit the code
>>> because this will break some application's behavior.
>>>
>>> [What to Change]
>>> I am going to remove elm_genlist_item_update() from
>>> elm_genlist_item_data_set() API soon.
>>>
>>> Currently, elm_genlist_item_data_set() API calls
>>> elm_genlist_item_update() API internally.
>>>
>>>
>>> Index: elm_genlist.c
>>> ===================================================================
>>> --- elm_genlist.c (revision 61455)
>>> +++ elm_genlist.c (working copy)
>>> @@ -4777,9 +4777,9 @@ elm_genlist_item_del(Elm_Genlist_Item *it)
>>> * Set the data item from the genlist item
>>> *
>>> * This set the data value passed on the elm_genlist_item_append() and
>>> - * related item addition calls. This function will also call
>>> - * elm_genlist_item_update() so the item will be updated to reflect the
>>> - * new data.
>>> + * related item addition calls. This function will not call
>>> + * elm_genlist_item_update() anymore. So call elm_genlist_item_update()
>>> + * manually only when it's needed.
>>> *
>>> * @param it The item
>>> * @param data The new data pointer to set
>>> @@ -4792,7 +4792,6 @@ elm_genlist_item_data_set(Elm_Genlist_Item *it,
>>> {
>>> ELM_WIDGET_ITEM_WIDTYPE_CHECK_OR_RETURN(it);
>>> elm_widget_item_data_set(it, data);
>>> - elm_genlist_item_update(it);
>>> }
>>>
>>
>
------------------------------------------------------------------------------
5 Ways to Improve & Secure Unified Communications
Unified Communications promises greater efficiencies for business. UC can
improve internal communications as well as offer faster, more efficient ways
to interact with customers and streamline customer service. Learn more!
http://www.accelacomm.com/jaw/sfnl/114/51426253/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
