On Sat, 23 Jul 2011 22:22:10 +0900 Jihoon Kim <imfin...@gmail.com> said:
i fixed this one in svn already :) > Hi, Naruto. > > I've tested in elementary_test > entry menu after applying my edje patch > related to client_window_set. > However, I couldn't see the preedit string in the entry widget while I was > typing. > > In addition, sometimes segmentation fault was occured. > Here is backtrace of GDB. > > (gdb) bt > #0 0x0030fb62 in eina_unicode_strlen (ustr=0x0) at eina_unicode.c:70 > #1 0x003105dc in eina_unicode_unicode_to_utf8 (uni=0x0, _len=0xbffff184) > at eina_unicode.c:331 > #2 0x00efd7b3 in _ecore_imf_context_xim_preedit_string_get (ctx=0x8251b28, > str=0xbffff1d8, cursor_pos=0xbffff1dc) at ecore_imf_xim.c:179 > #3 0x004736d6 in ecore_imf_context_preedit_string_get (ctx=0x8251b28, > str=0xbffff1d8, cursor_pos=0xbffff1dc) at ecore_imf_context.c:388 > #4 0x004d4c44 in _edje_entry_imf_event_preedit_changed_cb (data=0x8333628, > type=79, event=0x838f0b8) at edje_entry.c:2887 > #5 0x00428ac6 in _ecore_event_call () at ecore_events.c:693 > #6 0x0042f4d2 in _ecore_main_loop_iterate_internal (once_only=0) > at ecore_main.c:1750 > #7 0x0042dc49 in ecore_main_loop_begin () at ecore_main.c:848 > #8 0x001d08cc in elm_run () at elm_main.c:1075 > #9 0x0805551b in elm_main (argc=1, argv=0xbffff3a4) at test.c:489 > #10 0x08055554 in main (argc=1, argv=0xbffff3a4) at test.c:498 > > 2011/7/23 Naruto TAKAHASHI <tnar...@gmail.com> > > > Hi JihoonKim, and EFL developers. > > > > I attach a patch for fixing some XIM module bugs. > > > > - fix showing previous preedit string bug. > > - delete compile warning(thanks JihoonKim) > > - fix some sequence issue to send preedit changed event and commit > > event.(thanks JihoonKim) > > > > Please review this patch? > > > > Regards. > > > > 2011年7月22日23:52 Naruto TAKAHASHI <tnar...@gmail.com>: > > > Hi, JihoonKim. > > > > > > I talked to you how fix "preedit draw callback " direction on IRC. > > > I repeat to talk this stuff for didn't see this talk. > > > > > > Your patch behavior is no problem. > > > But Preedit Draw Callback needs insert, delete, and replace by > > > referencing Preedit Draw Callback argument. > > > (detail: > > http://static.cray-cyber.org/Documentation/NEC_SX_R10_1/G1AE02E/CHAP13.HTML#13.18.6 > > . > > > Preedit Draw Callback) > > > > > > I'm trying to fix too easy routine by using Eina_UStrBuf, now. > > > > > > So, please wait this. > > > Off course, I merge deleting comple warning of your patch with thanks. :) > > > > > > Thanks. > > > > > > 2011/7/17 Jihoon Kim <imfin...@gmail.com>: > > >> Hi, Naruto. > > >> As I told you last Friday on IRC, I guess there are some bugs in your > > xim > > >> immodule. > > >> For example, in case that I'd like to input '私の' (watasino), the > > >> preedit string was got from your immodule like below > > >> '私のしの'. > > >> In addition, there are some sequence issue to send preedit changed event > > and > > >> commit event. > > >> I've tried to fix this problem and send you the patch. > > >> (I've tested on elementary_test > entry) > > >> If you don't mind uploading this patch to svn, I'll request Maintainers > > to > > >> upload this patch. > > >> Thanks. > > >> On Sun, Jul 10, 2011 at 2:51 AM, Naruto TAKAHASHI <tnar...@gmail.com> > > wrote: > > >>> > > >>> Hi Mike. > > >>> > > >>> Thanks, feedback. I merged it to xim/Makefile.am. > > >>> > > >>> I attach a source code for using XIM module debug. > > >>> This program can check a below behaviors. > > >>> > > >>> - toggle enable and disable XIM > > >>> - commit string from XIM > > >>> > > >>> Another test, by using Desktop Entry Editor's text field. > > >>> (Enlightenment Main->Settings->Settings Panel->New Application) > > >>> > > >>> When executing test program, set ECORE_IMF_MODULE=xim. > > >>> > > >>> Thanks. > > >>> > > >>> 2011/7/8 Mike McCormack <mj.mccorm...@samsung.com>: > > >>> > On 07/08/2011 03:15 PM, Naruto TAKAHASHI wrote: > > >>> >> Hi, All. > > >>> >> > > >>> >> I attached some patches of XIM module of ecore_imf. > > >>> >> > > >>> >> As far as I know, EFL has not having official ecore_imf module in E > > >>> >> repository. And ecore_x has XIM code but is unavailable condition. > > >>> >> So I moved XIM code of ecore_x as ecore_imf module. > > >>> >> > > >>> >> please review this patches. > > >>> > > > >>> > Hello Naruto, > > >>> > > > >>> > Looks like nice work. > > >>> > > > >>> > I applied your patches to my ecore and built, but there was a build > > >>> > error (fix below): > > >>> > > > >>> > make[5]: Entering directory > > >>> > `/home/mike/git/e/ecore/src/modules/immodules/xim' > > >>> > CC xim_la-ecore_imf_xim.lo > > >>> > ecore_imf_xim.c:5:18: error: Evas.h: No such file or directory > > >>> > ecore_imf_xim.c: In function ‘_ecore_x_event_reverse_locks’: > > >>> > ecore_imf_xim.c:359: warning: suggest braces around empty body in an > > >>> > ‘if’ statement > > >>> > ecore_imf_xim.c: In function ‘preedit_start_callback’: > > >>> > ecore_imf_xim.c:662: warning: unused parameter ‘xic’ > > >>> > ecore_imf_xim.c:664: warning: unused parameter ‘call_data’ > > >>> > > > >>> > How can I test it? > > >>> > > > >>> > thanks, > > >>> > > > >>> > Mike > > >>> > > > >>> > > > >>> > > > >>> > diff --git a/ecore/src/modules/immodules/xim/Makefile.am > > >>> > b/ecore/src/modules/immodules/xim/Makefile.am > > >>> > index 006035c..cc0682d 100644 > > >>> > --- a/ecore/src/modules/immodules/xim/Makefile.am > > >>> > +++ b/ecore/src/modules/immodules/xim/Makefile.am > > >>> > @@ -12,6 +12,7 @@ AM_CPPFLAGS = \ > > >>> > -I$(top_builddir)/src/lib/ecore_imf \ > > >>> > -DPACKAGE_LIB_DIR=\"$(libdir)\" \ > > >>> > -DPACKAGE_DATA_DIR=\"$(datadir)/$(PACKAGE)\" \ > > >>> > +@EVAS_CFLAGS@ \ > > >>> > @EINA_CFLAGS@ > > >>> > > > >>> > pkgdir = $(libdir)/ecore/immodules > > >>> > > > >>> > > > >>> > > > >>> > > > ------------------------------------------------------------------------------ > > >>> > All of the data generated in your IT infrastructure is seriously > > >>> > valuable. > > >>> > Why? It contains a definitive record of application performance, > > >>> > security > > >>> > threats, fraudulent activity, and more. Splunk takes this data and > > makes > > >>> > sense of it. IT sense. And common sense. > > >>> > http://p.sf.net/sfu/splunk-d2d-c2 > > >>> > _______________________________________________ > > >>> > enlightenment-devel mailing list > > >>> > enlightenment-devel@lists.sourceforge.net > > >>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >>> > > > >>> > > >>> > > >>> > > >>> -- > > >>> Naruto TAKAHASHI > > >>> tnar...@gmail.com > > >>> > > >>> > > >>> > > ------------------------------------------------------------------------------ > > >>> All of the data generated in your IT infrastructure is seriously > > valuable. > > >>> Why? It contains a definitive record of application performance, > > security > > >>> threats, fraudulent activity, and more. Splunk takes this data and > > makes > > >>> sense of it. IT sense. And common sense. > > >>> http://p.sf.net/sfu/splunk-d2d-c2 > > >>> _______________________________________________ > > >>> enlightenment-devel mailing list > > >>> enlightenment-devel@lists.sourceforge.net > > >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >>> > > >> > > >> > > > > > > > > > > > > -- > > > Naruto TAKAHASHI > > > tnar...@gmail.com > > > > > > > > > > > -- > > Naruto TAKAHASHI > > tnar...@gmail.com > > > ------------------------------------------------------------------------------ > Storage Efficiency Calculator > This modeling tool is based on patent-pending intellectual property that > has been used successfully in hundreds of IBM storage optimization engage- > ments, worldwide. Store less, Store more with what you own, Move data to > the right place. Try It Now! http://www.accelacomm.com/jaw/sfnl/114/51427378/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Magic Quadrant for Content-Aware Data Loss Prevention Research study explores the data loss prevention market. Includes in-depth analysis on the changes within the DLP market, and the criteria used to evaluate the strengths and weaknesses of these DLP solutions. http://www.accelacomm.com/jaw/sfnl/114/51385063/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
