On Sat, 23 Jul 2011 19:14:36 +0900 Naruto TAKAHASHI <tnar...@gmail.com> said:
fixes patch in - warnings were already fixed :) > Hi, Vencent. > > (I forgeted adding e-devel ML address to Cc. So send again.) > > > split your patch in 3 patches (the 3 things above). Or at least 2 patches > > (one for the warnings, the other for the fixes). > > I split my patch to 2 paches. one for warnings, the other for fixes. > > Thanks. > > 2011/7/23 Vincent Torri <vto...@univ-evry.fr>: > > > > hey > > > > On Sat, 23 Jul 2011, Naruto TAKAHASHI wrote: > > > >> Hi JihoonKim, and EFL developers. > >> > >> I attach a patch for fixing some XIM module bugs. > >> > >> - fix showing previous preedit string bug. > >> - delete compile warning(thanks JihoonKim) > >> - fix some sequence issue to send preedit changed event and commit > >> event.(thanks JihoonKim) > >> > >> Please review this patch? > > > > split your patch in 3 patches (the 3 things above). Or at least 2 patches > > (one for the warnings, the other for the fixes). > > > > Vincent > > > >> Regards. > >> > >> 2011年7月22日23:52 Naruto TAKAHASHI <tnar...@gmail.com>: > >>> > >>> Hi, JihoonKim. > >>> > >>> I talked to you how fix "preedit draw callback " direction on IRC. > >>> I repeat to talk this stuff for didn't see this talk. > >>> > >>> Your patch behavior is no problem. > >>> But Preedit Draw Callback needs insert, delete, and replace by > >>> referencing Preedit Draw Callback argument. > >>> (detail: > >>> http://static.cray-cyber.org/Documentation/NEC_SX_R10_1/G1AE02E/CHAP13.HTML#13.18.6. > >>> Preedit Draw Callback) > >>> > >>> I'm trying to fix too easy routine by using Eina_UStrBuf, now. > >>> > >>> So, please wait this. > >>> Off course, I merge deleting comple warning of your patch with thanks. :) > >>> > >>> Thanks. > >>> > >>> 2011/7/17 Jihoon Kim <imfin...@gmail.com>: > >>>> > >>>> Hi, Naruto. > >>>> As I told you last Friday on IRC, I guess there are some bugs in your > >>>> xim > >>>> immodule. > >>>> For example, in case that I'd like to input '私の' (watasino), the > >>>> preedit string was got from your immodule like below > >>>> '私のしの'. > >>>> In addition, there are some sequence issue to send preedit changed event > >>>> and > >>>> commit event. > >>>> I've tried to fix this problem and send you the patch. > >>>> (I've tested on elementary_test > entry) > >>>> If you don't mind uploading this patch to svn, I'll request Maintainers > >>>> to > >>>> upload this patch. > >>>> Thanks. > >>>> On Sun, Jul 10, 2011 at 2:51 AM, Naruto TAKAHASHI <tnar...@gmail.com> > >>>> wrote: > >>>>> > >>>>> Hi Mike. > >>>>> > >>>>> Thanks, feedback. I merged it to xim/Makefile.am. > >>>>> > >>>>> I attach a source code for using XIM module debug. > >>>>> This program can check a below behaviors. > >>>>> > >>>>> - toggle enable and disable XIM > >>>>> - commit string from XIM > >>>>> > >>>>> Another test, by using Desktop Entry Editor's text field. > >>>>> (Enlightenment Main->Settings->Settings Panel->New Application) > >>>>> > >>>>> When executing test program, set ECORE_IMF_MODULE=xim. > >>>>> > >>>>> Thanks. > >>>>> > >>>>> 2011/7/8 Mike McCormack <mj.mccorm...@samsung.com>: > >>>>>> > >>>>>> On 07/08/2011 03:15 PM, Naruto TAKAHASHI wrote: > >>>>>>> > >>>>>>> Hi, All. > >>>>>>> > >>>>>>> I attached some patches of XIM module of ecore_imf. > >>>>>>> > >>>>>>> As far as I know, EFL has not having official ecore_imf module in E > >>>>>>> repository. And ecore_x has XIM code but is unavailable condition. > >>>>>>> So I moved XIM code of ecore_x as ecore_imf module. > >>>>>>> > >>>>>>> please review this patches. > >>>>>> > >>>>>> Hello Naruto, > >>>>>> > >>>>>> Looks like nice work. > >>>>>> > >>>>>> I applied your patches to my ecore and built, but there was a build > >>>>>> error (fix below): > >>>>>> > >>>>>> make[5]: Entering directory > >>>>>> `/home/mike/git/e/ecore/src/modules/immodules/xim' > >>>>>> CC xim_la-ecore_imf_xim.lo > >>>>>> ecore_imf_xim.c:5:18: error: Evas.h: No such file or directory > >>>>>> ecore_imf_xim.c: In function ‘_ecore_x_event_reverse_locks’: > >>>>>> ecore_imf_xim.c:359: warning: suggest braces around empty body in an > >>>>>> ‘if’ statement > >>>>>> ecore_imf_xim.c: In function ‘preedit_start_callback’: > >>>>>> ecore_imf_xim.c:662: warning: unused parameter ‘xic’ > >>>>>> ecore_imf_xim.c:664: warning: unused parameter ‘call_data’ > >>>>>> > >>>>>> How can I test it? > >>>>>> > >>>>>> thanks, > >>>>>> > >>>>>> Mike > >>>>>> > >>>>>> > >>>>>> > >>>>>> diff --git a/ecore/src/modules/immodules/xim/Makefile.am > >>>>>> b/ecore/src/modules/immodules/xim/Makefile.am > >>>>>> index 006035c..cc0682d 100644 > >>>>>> --- a/ecore/src/modules/immodules/xim/Makefile.am > >>>>>> +++ b/ecore/src/modules/immodules/xim/Makefile.am > >>>>>> @@ -12,6 +12,7 @@ AM_CPPFLAGS = \ > >>>>>> -I$(top_builddir)/src/lib/ecore_imf \ > >>>>>> -DPACKAGE_LIB_DIR=\"$(libdir)\" \ > >>>>>> -DPACKAGE_DATA_DIR=\"$(datadir)/$(PACKAGE)\" \ > >>>>>> +@EVAS_CFLAGS@ \ > >>>>>> @EINA_CFLAGS@ > >>>>>> > >>>>>> pkgdir = $(libdir)/ecore/immodules > >>>>>> > >>>>>> > >>>>>> > >>>>>> > >>>>>> ------------------------------------------------------------------------------ > >>>>>> All of the data generated in your IT infrastructure is seriously > >>>>>> valuable. > >>>>>> Why? It contains a definitive record of application performance, > >>>>>> security > >>>>>> threats, fraudulent activity, and more. Splunk takes this data and > >>>>>> makes > >>>>>> sense of it. IT sense. And common sense. > >>>>>> http://p.sf.net/sfu/splunk-d2d-c2 > >>>>>> _______________________________________________ > >>>>>> enlightenment-devel mailing list > >>>>>> enlightenment-devel@lists.sourceforge.net > >>>>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >>>>>> > >>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> Naruto TAKAHASHI > >>>>> tnar...@gmail.com > >>>>> > >>>>> > >>>>> > >>>>> ------------------------------------------------------------------------------ > >>>>> All of the data generated in your IT infrastructure is seriously > >>>>> valuable. > >>>>> Why? It contains a definitive record of application performance, > >>>>> security > >>>>> threats, fraudulent activity, and more. Splunk takes this data and > >>>>> makes > >>>>> sense of it. IT sense. And common sense. > >>>>> http://p.sf.net/sfu/splunk-d2d-c2 > >>>>> _______________________________________________ > >>>>> enlightenment-devel mailing list > >>>>> enlightenment-devel@lists.sourceforge.net > >>>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >>>>> > >>>> > >>>> > >>> > >>> > >>> > >>> -- > >>> Naruto TAKAHASHI > >>> tnar...@gmail.com > >>> > >> > >> > >> > >> -- > >> Naruto TAKAHASHI > >> tnar...@gmail.com > > > > > > -- > Naruto TAKAHASHI > tnar...@gmail.com -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Magic Quadrant for Content-Aware Data Loss Prevention Research study explores the data loss prevention market. Includes in-depth analysis on the changes within the DLP market, and the criteria used to evaluate the strengths and weaknesses of these DLP solutions. http://www.accelacomm.com/jaw/sfnl/114/51385063/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
