On Thu, 4 Aug 2011, Carsten Haitzler (The Rasterman) wrote:
> On Thu, 4 Aug 2011 09:18:30 +0200 (CEST) Vincent Torri <vto...@univ-evry.fr> > said: > >> >> >> On Fri, 29 Jul 2011, Vincent Torri wrote: >> >>>> >>>>> On Fri, 29 Jul 2011 06:57:33 +0200 (CEST) Vincent Torri >>>>> <vto...@univ-evry.fr> >>>>> said: >>>>> >>>>>>> Secondly, this code is disabled, so it shouldn't affect anything right >>>>>>> now. >>>>>>> As I understand, it's normal in EFL development to add code that is >>>>>>> disabled, debug it, then enable it later when it works. >>>>>> >>>>>> no. It's not normal at all. >>>>> >>>>> of course it is! i've been doing this for YEARS! adding new features that >>>>> u >>>>> need to either compile-time enable or runtime enable to use/see. is not >>>>> ecore-xcb exactly that? what about all of the loaders fo eavs, or >>>>> engines... >>>>> or... i can go on. >>>> >>>> except for ecore_xcb (my code, before devilhorns' changes), the code was >>>> always functional and of good, or high quality. According to cedric, the >>>> code here will not work at all on some important cases. >>> >>> and I repeat what i told you on IRC : these changes are in the most >>> important part of the EFL : the main loop. Also, doing such critical >>> change, even if it is optional, **just before** a release (if I'm not >>> mistaken the release is for september) is just masochism (as people will >>> use it if it is in a release, even if it is optional) >>> >>> so again, I'm against that commit. Add it later if you want (you're the >>> maintianer, so you do what you want), but now, for such critical change, >>> it's not good at all. >> >> i'm still waiting for your answer... > > i already said my piece. its not that complex (as a commit) and its turned off > and it WORKS. NOW. it's showing any problems. there's a chunk of xcb work > going > on too - you want to remove that too? we haven't called a freeze yet. so > you're > jumping the gun. so, as discomfitor said, last year you removed some piece of code saying that it was too untested and the release being too close. There is the same case here, and you don't remove it... Vincent ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
