On Tue, Aug 9, 2011 at 5:50 AM, Enlightenment SVN
<no-re...@enlightenment.org> wrote:
>  EAPI void
>  ecore_app_args_get(int *argc, char ***argv)
>  {
> -   ECORE_MAIN_LOOP_ASSERT();
> +   EINA_MAIN_LOOP_CHECK_RETURN;
>
>    if (argc) *argc = app_argc;
>    if (argv) *argv = app_argv;

there is no way to know if it failed or not, so at least zero *argc, *argv.


>  static inline void _ecore_lock(void)
>   {
>      /* at least check we're not being called from a thread */
> -     ECORE_MAIN_LOOP_ASSERT();
> +     EINA_MAIN_LOOP_CHECK_RETURN;

looking at the macro names, it's likely better to abort (assert) than
to just return.

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

------------------------------------------------------------------------------
uberSVN's rich system and user administration capabilities and model 
configuration take the hassle out of deploying and managing Subversion and 
the tools developers use with it. Learn more about uberSVN and get a free 
download at:  http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to