On Tue, Aug 9, 2011 at 11:48 AM, Gustavo Sverzut Barbieri
<[email protected]> wrote:
> On Tue, Aug 9, 2011 at 5:50 AM, Enlightenment SVN
> <[email protected]> wrote:
>>  EAPI void
>>  ecore_app_args_get(int *argc, char ***argv)
>>  {
>> -   ECORE_MAIN_LOOP_ASSERT();
>> +   EINA_MAIN_LOOP_CHECK_RETURN;
>>
>>    if (argc) *argc = app_argc;
>>    if (argv) *argv = app_argv;
>
> there is no way to know if it failed or not, so at least zero *argc, *argv.

Yep, will do. Make complete sense.

>>  static inline void _ecore_lock(void)
>>   {
>>      /* at least check we're not being called from a thread */
>> -     ECORE_MAIN_LOOP_ASSERT();
>> +     EINA_MAIN_LOOP_CHECK_RETURN;
>
> looking at the macro names, it's likely better to abort (assert) than
> to just return.

This function will be removed in a near futur, that was a quick
workaround a mess.
-- 
Cedric BAIL

------------------------------------------------------------------------------
uberSVN's rich system and user administration capabilities and model 
configuration take the hassle out of deploying and managing Subversion and 
the tools developers use with it. Learn more about uberSVN and get a free 
download at:  http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to