Yeah, I've seen ecrustify but I think when testing it, it didn't give good results and from what I could perceive, other devs don't seem to trust it to work reliably which is why I put efl-indent in there. Also I believe using a tested and used GNU app is better than using a custom made one that might have bugs, and being able to easily configure the output using arguments to indent makes it better than looking through ecrustify to figure out what causes it to format a line the wrong way. As for the format, I configured efl-indent to match what the wiki says (other than one bug I'm not sure how to change, need to read the man page), but the current issues is with the fact that each file seem to use a different coding style (or different styles within the same file) and I'm not sure what to do with these as they are undocumented in the wiki.
p.s: for trailing spaces (which is this mail's original subject), I use a sed line in efl-indent to take care of that, at least that could safely be put into a svn hook while we figure out the coding style issue. On Fri, Oct 21, 2011 at 10:14 PM, Carsten Haitzler <ras...@rasterman.com>wrote: > On Fri, 21 Oct 2011 14:44:31 -0400 Youness Alaoui > <kakar...@kakaroto.homelinux.net> said: > > > Ha! I was about to start a thread about this specific issue! > > I don't know if you noticed but I added a 'efl-indent' script in > FORMATTING > > which uses GNU's indent. That works very good, and is used by GStreamer > to > > do their code formatting. > > GStreamer uses git and when you try to commit something that doesn't > match > > the formatting code, it will not let you commit, and will show you how it > > should have been. > > Here is an example : http://pastie.org/2686190 > > I discussed this with SeoZ on #edevelop a couple of weeks ago. The script > > might need some tweaking (the man page of indent is quite extensive) to > fit > > the exact coding style of the efl (I think it's close now) but I noticed > a > > lot of things aren't standardized, like "struct { " with the accolades on > > the same line in some files and with it on separate lines in other files, > or > > the number of spaces between a variable type and its name in a > declaration > > (some align it, some don't), etc... all that stuff has to be defined and > > respected across the board. > > We can do a pre-commit hook in svn that would work just like its git > > counterpart in GStreamer. But we'd need to reindent all the files for it > to > > work, it could be done in a single commit but might cause conflicts to > devs, > > or do it one file at a time, whenever it gets modified by someone, he'd > > format it at the same time. > > What do you think ? > > umm that's why formatefl.sh is there. it actually gets very close to our > current > style. it has 1 annoying bug at the moment though. it actually compiles and > installs a custom re-formatter that's a fork of uncrustify that does a lot > more > than gnu indent does. the problem right now is in getting it to > consistently > 100% of the time format the right way. right now the bug it has in sticking > spaces before prototype functionames is annoying and going to lead to > commit > hooks probably locking out commits permanently. > > > KaKaRoTo > > > > On Fri, Oct 21, 2011 at 12:29 AM, Vincent Torri <vto...@univ-evry.fr> > wrote: > > > > > > > > > > > On Fri, 21 Oct 2011, Daniel Juyung Seo wrote: > > > > > > I raise this issue again. > > >> We need pre/post-commit hook for formatting, whitespaces, and > whatever. > > >> > > > > > > unfortunately, these hook will imply a lot of conflicts > > > > > > Vincent > > > > > > > > > webkit already does this job. > > >> > > >> Daniel Juyung Seo (SeoZ) > > >> > > >> On Tue, Jun 21, 2011 at 10:00 PM, David Seikel <onef...@gmail.com> > wrote: > > >> > > >>> On Tue, 21 Jun 2011 13:43:13 +0200 Thomas Gstädtner > > >>> <tho...@gstaedtner.net> wrote: > > >>> > > >>> That is true, but the "Don't do that, nasty programmer. SPANK SPANK > > >>>> SPANK" mail tells you that the hook triggered and also it hurts the > > >>>> programmer who did produce the trailing whitespaces. People learn > best > > >>>> when it hurts :P > > >>>> > > >>> > > >>> Automated emails might just go to spam, don't hurt that much. Unless > > >>> you intend to not accept the commit and make them do it over. That > > >>> will hurt enough. > > >>> > > >>> -- > > >>> A big old stinking pile of genius that no one wants > > >>> coz there are too many silver coated monkeys in the world. > > >>> > > >>> > > >>> > ------------------------------------------------------------------------------ > > >>> EditLive Enterprise is the world's most technically advanced content > > >>> authoring tool. Experience the power of Track Changes, Inline Image > > >>> Editing and ensure content is compliant with Accessibility Checking. > > >>> http://p.sf.net/sfu/ephox-dev2dev > > >>> _______________________________________________ > > >>> enlightenment-devel mailing list > > >>> enlightenment-devel@lists.sourceforge.net > > >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >>> > > >>> > > >>> > > >> > > >> > ------------------------------------------------------------------------------ > > >> The demand for IT networking professionals continues to grow, and the > > >> demand for specialized networking skills is growing even more rapidly. > > >> Take a complimentary Learning@Cisco Self-Assessment and learn > > >> about Cisco certifications, training, and career opportunities. > > >> http://p.sf.net/sfu/cisco-dev2dev > > >> _______________________________________________ > > >> enlightenment-devel mailing list > > >> enlightenment-devel@lists.sourceforge.net > > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > >> > > >> > > > > > > > ------------------------------------------------------------------------------ > > > The demand for IT networking professionals continues to grow, and the > > > demand for specialized networking skills is growing even more rapidly. > > > Take a complimentary Learning@Cisco Self-Assessment and learn > > > about Cisco certifications, training, and career opportunities. > > > http://p.sf.net/sfu/cisco-dev2dev > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > ------------------------------------------------------------------------------ > > The demand for IT networking professionals continues to grow, and the > > demand for specialized networking skills is growing even more rapidly. > > Take a complimentary Learning@Cisco Self-Assessment and learn > > about Cisco certifications, training, and career opportunities. > > http://p.sf.net/sfu/cisco-dev2dev > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > ------------------------------------------------------------------------------ > The demand for IT networking professionals continues to grow, and the > demand for specialized networking skills is growing even more rapidly. > Take a complimentary Learning@Cisco Self-Assessment and learn > about Cisco certifications, training, and career opportunities. > http://p.sf.net/sfu/cisco-dev2dev > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
