Dear all
I made a bug fix for elm_map.
When a downloaded image has an error, , elm_map removes a file and goes on
just like download succeeded .
However, it is not success, so it should be marked as FALSE for later
retry.
Can anyone review this simple patch? :)
Index: elm_map.c
===================================================================
--- elm_map.c (리비전 64538)
+++ elm_map.c (작업 사본)
@@ -1186,7 +1186,12 @@ _tile_update(Grid_Item *gi)
gi->download = EINA_FALSE;
evas_object_image_file_set(gi->img, gi->file, NULL);
if (evas_object_image_load_error_get(gi->img) != EVAS_LOAD_ERROR_NONE)
- ecore_file_remove(gi->file);
+ {
+ WRN("Image loading error (%s)", gi->file);
+ ecore_file_remove(gi->file);
+ gi->have = EINA_FALSE;
+ return;
+ }
obj_rotate_zoom(gi->wd->obj, gi->img);
evas_object_show(gi->img);
Index: elm_map.c
===================================================================
--- elm_map.c (리비전 64538)
+++ elm_map.c (작업 사본)
@@ -1186,7 +1186,12 @@ _tile_update(Grid_Item *gi)
gi->download = EINA_FALSE;
evas_object_image_file_set(gi->img, gi->file, NULL);
if (evas_object_image_load_error_get(gi->img) != EVAS_LOAD_ERROR_NONE)
- ecore_file_remove(gi->file);
+ {
+ ERR("Image loading error (%s)", gi->file);
+ ecore_file_remove(gi->file);
+ gi->have = EINA_FALSE;
+ return;
+ }
obj_rotate_zoom(gi->wd->obj, gi->img);
evas_object_show(gi->img);
------------------------------------------------------------------------------
Get your Android app more play: Bring it to the BlackBerry PlayBook
in minutes. BlackBerry App World™ now supports Android™ Apps
for the BlackBerry® PlayBook™. Discover just how easy and simple
it is! http://p.sf.net/sfu/android-dev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
