On Mon, 31 Oct 2011 14:54:19 +0900 Bluezery <[email protected]> said:
> Dear all
>
> I made a bug fix for elm_map.
> When a downloaded image has an error, , elm_map removes a file and goes on
> just like download succeeded .
> However, it is not success, so it should be marked as FALSE for later
> retry.
>
> Can anyone review this simple patch? :)
i guess thats better than whats here. it really should be retrying too... i
should make it do that...
> Index: elm_map.c
> ===================================================================
> --- elm_map.c (리비전 64538)
> +++ elm_map.c (작업 사본)
> @@ -1186,7 +1186,12 @@ _tile_update(Grid_Item *gi)
> gi->download = EINA_FALSE;
> evas_object_image_file_set(gi->img, gi->file, NULL);
> if (evas_object_image_load_error_get(gi->img) != EVAS_LOAD_ERROR_NONE)
> - ecore_file_remove(gi->file);
> + {
> + WRN("Image loading error (%s)", gi->file);
> + ecore_file_remove(gi->file);
> + gi->have = EINA_FALSE;
> + return;
> + }
>
> obj_rotate_zoom(gi->wd->obj, gi->img);
> evas_object_show(gi->img);
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [email protected]
------------------------------------------------------------------------------
RSA® Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
