On Fri, Nov 4, 2011 at 10:37 AM, Mike Blumenkrantz <m...@zentific.com> wrote: > On Fri, 4 Nov 2011 05:12:40 -0700 > "Enlightenment SVN" <no-re...@enlightenment.org> wrote: > >> Log: >> Add a getter for DBusConnection pointer from E_DBus_Connection. >> >> Author: sanjeev >> Date: 2011-11-04 05:12:40 -0700 (Fri, 04 Nov 2011) >> New Revision: 64728 >> Trac: http://trac.enlightenment.org/e/changeset/64728 >> >> Modified: >> trunk/e_dbus/src/lib/dbus/E_DBus.h >> trunk/e_dbus/src/lib/dbus/e_dbus_object.c > Your doxygen is wrong, you didn't add @since, you didn't update the Changelog, > and your formatting does not follow EFL conventions.
And... this is the function "e_dbus_connection_dbus_connection_get(E_DBus_Connection *conn)", which is internal and shouldn't be exported. Why are you exporting it? Lucas De Marchi ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel