Mike Z, I did not notice the API mentioned by Lucas. It would be sufficient to export that one. I can revert the commit that I made and change elev8 to use the existing API.
Lucas, I am trying to write dbus support for elev8 and for introspection (sync) I need to use libdbus API. (I am using both e_dbus and libdbus API in the implementation.) libdbus API needs DBusConnection and hence I need to export it. Regards, Sanjeev On Fri, Nov 4, 2011 at 10:24 PM, Mike Blumenkrantz <m...@zentific.com>wrote: > On Fri, 4 Nov 2011 11:17:40 -0200 > Lucas De Marchi <lucas.demar...@profusion.mobi> wrote: > > > On Fri, Nov 4, 2011 at 10:37 AM, Mike Blumenkrantz <m...@zentific.com> > wrote: > > > On Fri, 4 Nov 2011 05:12:40 -0700 > > > "Enlightenment SVN" <no-re...@enlightenment.org> wrote: > > > > > >> Log: > > >> Add a getter for DBusConnection pointer from E_DBus_Connection. > > >> > > >> Author: sanjeev > > >> Date: 2011-11-04 05:12:40 -0700 (Fri, 04 Nov 2011) > > >> New Revision: 64728 > > >> Trac: http://trac.enlightenment.org/e/changeset/64728 > > >> > > >> Modified: > > >> trunk/e_dbus/src/lib/dbus/E_DBus.h > > >> trunk/e_dbus/src/lib/dbus/e_dbus_object.c > > > Your doxygen is wrong, you didn't add @since, you didn't update the > > > Changelog, and your formatting does not follow EFL conventions. > > > > And... this is the function > > "e_dbus_connection_dbus_connection_get(E_DBus_Connection *conn)", > > which is internal and shouldn't be exported. Why are you exporting it? > > > > > > Lucas De Marchi > > > He claimed he needed it for some v8 nonsense so I said okay. > > -- > Mike Blumenkrantz > Zentific: Doctor recommended, mother approved. > > > ------------------------------------------------------------------------------ > RSA(R) Conference 2012 > Save $700 by Nov 18 > Register now > http://p.sf.net/sfu/rsa-sfdev2dev1 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
