On 15/12/11 08:11, Daniel Juyung Seo wrote: > Overall idea looks good. > > 1) wrap 80 chars >> evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_RESIZE, >> _rect_resize_cb, obj); > > This is too long. EFL sources are written based on 80 chars per line policy. > Please wrap them correctly. > > 2) remove unrelated changes > Check config/profile.src, src/bin/test_map.c > > 3) setter/getter apis > We should also set the configuration by apis. > ex) elm_password_show_last_get/set > It looks like glayer has no configurable apis. I need Tom's comment for this.
I wanted to comment, but Daniel already said it all :P With the same line of thinking, what about rotation with fingers? lines with fingers? what should be done in those cases? Does Apple really have patents for pinch to zoom? ffs with those damn idiotic patents. Anyhow, please follow Daniel's suggestions, and then I'll review it again. -- Tom. ------------------------------------------------------------------------------ 10 Tips for Better Server Consolidation Server virtualization is being driven by many needs. But none more important than the need to reduce IT complexity while improving strategic productivity. Learn More! http://www.accelacomm.com/jaw/sdnl/114/51507609/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
