On Thu, 15 Dec 2011 15:11:11 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> said:
> Overall idea looks good. > > 1) wrap 80 chars > > evas_object_event_callback_add(wd->rect, EVAS_CALLBACK_RESIZE, > > _rect_resize_cb, obj); > > This is too long. EFL sources are written based on 80 chars per line policy. > Please wrap them correctly. indeed we try to keep to 80 chars - tho u believe that current format-efl stuff will make lines long and unwrap them. i've come to the conclusion that u cant keep to 80 chars unless you do it by hand - automated wrapping has in every instance always ended up failing :( > 2) remove unrelated changes > Check config/profile.src, src/bin/test_map.c > > 3) setter/getter apis > We should also set the configuration by apis. > ex) elm_password_show_last_get/set > It looks like glayer has no configurable apis. I need Tom's comment for this. > > Thanks. > > Daniel Juyung Seo (SeoZ) > > On Thu, Dec 15, 2011 at 2:14 PM, Bluezery <ohpo...@gmail.com> wrote: > > Dear all, > > > > Elementary can be used for all because EFL is an open source. > > But multi Touch event can have paten issue such as pinch zooming action. > > So, I add "finger(pinch) zooming action" to elm_config to can be > > enabled or disabled. > > This configuration value can be used for diverse product. > > It's my pleasure if Mr. Hacohen have time to review this. :-) > > > > Only gesture layer recognizes this value if all other elementary is > > based on gesture layer. > > But elm map implemented pinch zooming by itself. I will change elm_map > > to use gesture layer soon. > > For the consistency, elm_map read this value temporarily. It will > > removed later after gesture layer is applied. > > > > Please review this patch. > > > > -- > > BRs, > > Kim. > > > > ------------------------------------------------------------------------------ > > 10 Tips for Better Server Consolidation > > Server virtualization is being driven by many needs. > > But none more important than the need to reduce IT complexity > > while improving strategic productivity. Learn More! > > http://www.accelacomm.com/jaw/sdnl/114/51507609/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ------------------------------------------------------------------------------ > 10 Tips for Better Server Consolidation > Server virtualization is being driven by many needs. > But none more important than the need to reduce IT complexity > while improving strategic productivity. Learn More! > http://www.accelacomm.com/jaw/sdnl/114/51507609/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
