On 19/01/12 12:29, David Seikel wrote:
> You just broke API.  Those %y1 and friends in the strings used by the
> _elua_scan_params() and _elua_ret() functions are the names of Lua
> arguments and return values.  The Lua scripts expect to have these
> names as table fields when calling these functions.  As such, they
> don't clash with any posix functions, as the names are local to the
> tables, and Lua does not use posix names anyway. But the Lua side does
> expect these names to be used, so you just broke the API.
>
> Also note that you may now be clashing with yy* names in lexers and
> yaccers.

I'm sorry. :(( Please revert my patch.
>
> In this case, all these variables are LOCAL, so how can they clash with
> any posix name that's not being used anyway?

y1 is a posix math function that's included by math.h. Using y1 thus 
triggers a shadow warning (which is something we want to know about. Use 
-Wshadow).

So y1 shadows a local declaration. If you can fine tune fix it so it'll 
keep the API but not shadow variables, that would be great.

Thanks,
Tom.


------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to