Thank you very much cnook. I have some brief comments here. 1. actionslider 'switch-case' indentation is wrong. Please check below e-coding style page. http://trac.enlightenment.org/e/wiki/ECoding And for elm_actionslider_enabled_pos_get, how about printing it like below? "actionslider enabled pos: left, right"
2. bg Trailing white space in line 14. But this patch looks ok. I removed the trailing white space. In SVN! 3. box Use elm_win_util_standard_add() instead of elm_win_add + elm_bg_add for convenience. elm_scroller_bounce_set(sc, 0, 1); -> Use EINA_FALSE, EINA_TRUE for Eina_Bool for consistency. Fix formatting. Remove unnecessary blank line. evas_object_size_hint_min_set(bg, 160, 160); evas_object_size_hint_max_set(bg, 640, 640); -> really needed? Daniel Juyung Seo (SeoZ) On Thu, Feb 16, 2012 at 10:20 AM, cnook <kimci...@gmail.com> wrote: > Dear All, Hello~ > > As you guess, the patch is for the elementary_test. > Please review the patch and give any feedbacks. > > The test_actionslider patch is mainly for elm_actionslider_xxx_get() APIs. > It would not be a good idea to add test code for such APIs. > So I have planed to add test code except elm_xxx_get() APIs > > Sincerely, > Shinwoo Kim. > > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
