Dear Daniel, Thanks! I have attached patch based on your comment.
And more.. elm_win_title_set(win, 0); makes CRASH. The last patch is for this. Please review this also and give any feedbacks. Sincerely, Shinwoo Kim. 2012/2/16 Daniel Juyung Seo <seojuyu...@gmail.com> > Thank you very much cnook. > I have some brief comments here. > > 1. actionslider > 'switch-case' indentation is wrong. Please check below e-coding style page. > http://trac.enlightenment.org/e/wiki/ECoding > And for elm_actionslider_enabled_pos_get, how about printing it like > below? > "actionslider enabled pos: left, right" > > 2. bg > Trailing white space in line 14. > But this patch looks ok. I removed the trailing white space. In SVN! > > 3. box > Use elm_win_util_standard_add() instead of elm_win_add + elm_bg_add for > convenience. > elm_scroller_bounce_set(sc, 0, 1); -> Use EINA_FALSE, EINA_TRUE for > Eina_Bool for consistency. > Fix formatting. > Remove unnecessary blank line. > > evas_object_size_hint_min_set(bg, 160, 160); > evas_object_size_hint_max_set(bg, 640, 640); > -> really needed? > > Daniel Juyung Seo (SeoZ) > > On Thu, Feb 16, 2012 at 10:20 AM, cnook <kimci...@gmail.com> wrote: > > > Dear All, Hello~ > > > > As you guess, the patch is for the elementary_test. > > Please review the patch and give any feedbacks. > > > > The test_actionslider patch is mainly for elm_actionslider_xxx_get() > APIs. > > It would not be a good idea to add test code for such APIs. > > So I have planed to add test code except elm_xxx_get() APIs > > > > Sincerely, > > Shinwoo Kim. > > > > > > > ------------------------------------------------------------------------------ > > Virtualization & Cloud Management Using Capacity Planning > > Cloud computing makes use of virtualization - but cloud computing > > also focuses on allowing computing to be delivered as a service. > > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >
test_actionslider.diff.2
Description: Binary data
test_box.diff.2
Description: Binary data
Index: src/lib/ecore_evas/ecore_evas_x.c
===================================================================
--- src/lib/ecore_evas/ecore_evas_x.c (revision 67995)
+++ src/lib/ecore_evas/ecore_evas_x.c (working copy)
@@ -2229,7 +2229,10 @@
{
if (ee->prop.title) free(ee->prop.title);
ee->prop.title = NULL;
- if (t) ee->prop.title = strdup(t);
+
+ if (!t) return;
+ ee->prop.title = strdup(t);
+
ecore_x_icccm_title_set(ee->prop.window, ee->prop.title);
ecore_x_netwm_name_set(ee->prop.window, ee->prop.title);
}
------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
