Hi, 
> On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohen<tom.haco...@samsung.com>  wrote:
> Your patch doesn't apply. Won't review.
>     

Some updates done during my patch creation & mailing time :( I will update and 
post it soon ).
   
> On 16/02/12 16:38, Gustavo Sverzut Barbieri wrote:> aside from that I wonder 
> what it offers on top of elm_layout. Maybe
> just add a canned layout as we do with others?
>
> how does it compare with inwin?
 
inwin will cover the entire area of the parent window and it can expand by 
setting its style to "minimal vertical".

Popup can be very small to almost full screen notification with partial 
transparent outer area.
Popup also supports screen orientations ( left,right,top, bottom etc, through 
Notify).
More over, there are marks to deprecate inwin ( refer the elm_win.h), so there 
is no alternate to elm_popup widget.


> Isn't it better to provide styles for notify and inwin?
>
>     
  Popup is custom widget ( elc_popup - enhancement over elm_notify ), 
simplifies application effort in showing either list  or any other 
content notification with title and action area buttons.  Perhaps, one can 
develop application with Evas & edje, but why do we have elm_layout, 
elm_separator, naviframe etc... Basically it simplifies  the development  and 
provides option to show notification with few lines of code( with 
uniform look & feel ).
> Whenever sending these patches, please elaborate on the need, the
> existing solutions and why they do not fit or why they are not
> fixable.
>     
 Features supported by Popup can still be implemented by using the existing 
widgets such as notify and custom layout having Title, content and action 
buttons as its internal parts.
 These features are supported on almost all leading UI widget tool kits as a 
widget similar to what Popup is supposed to do.
 Reason is pretty simple as this enables user to get all commonly used features 
like action button, title, content etc in a form of a single widget which helps 
in application development.
  Popup widget is self explanatory one ( common across all the UI toolkits ). 
its just matter of whether every 
application should write few hundred lines of C & EDC code  or just do with few 
lines of code with popup.
   
> It's a layout inside an elm_notify if I understand it correctly, I don't
> understand why such a simple widget should become to be 1450 lines.
>>     
> The code became large mostly because of the dynamic rearrangement support for 
> the internal action buttons when deleted and support for multiple content 
> parts including items.
   
  Popup supports  List Items with individual item add/delete feature, not just 
with that, also any layout/content .

> Also, I dislike the wrap_set API, I think it's awful.
>     
 This API has been added to help app developers control the wrapping of the 
content description text. Most of the time, mixed wrapping should be fine but 
if someone wants, word/char wrapping can be set using this API.

   
> On Feb 17, 2012 06:34 (GMT+05:30), Daniel Juyung Seo<seojuyu...@gmail.com>  
> wrote:
> I think Rajeev needs to have a solid explanation why popup is needed even 
> though we already have notify widget. 
> Rajeev, can you describe that?
> Thanks in advance.
> Daniel Juyung Seo (SeoZ)
     
 Popup reuses notify capability to orient itself based on need and resizing 
based on content minimum size.
 Encapsulating commonly used stuffs like title, content and action buttons 
allow app developers to reuse the commonly used features in the form of a 
widget.
 In addition to these parts, popup has support for items which helps in quickly 
adding the list of items and setting their internal content.

 Thank You.
 Regards,
 Rajeev




------- Original Message -------
Sender : Daniel Juyung Seo<seojuyu...@gmail.com>
Date : Feb 17, 2012 06:34 (GMT+05:30)
Title : Re: [E-devel] [Patch] Elementary: New custom widget Popup

I think Rajeev needs to have a solid explanation why popup is needed even 
though we already have notify widget.
Rajeev, can you describe that?


Thanks in advance.


Daniel Juyung Seo (SeoZ)


On Thu, Feb 16, 2012 at 11:43 PM, Tom Hacohen <tom.haco...@samsung.com> wrote:

On 16/02/12 16:38, Gustavo Sverzut Barbieri wrote:
> On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohen<tom.haco...@samsung.com>  wrote:
>> Your patch doesn't apply. Won't review.
>
> aside from that I wonder what it offers on top of elm_layout. Maybe
> just add a canned layout as we do with others?
>
> how does it compare with inwin?
>
> Isn't it better to provide styles for notify and inwin?
>
> Whenever sending these patches, please elaborate on the need, the
> existing solutions and why they do not fit or why they are not
> fixable.
>
>


It's a layout inside an elm_notify if I understand it correctly, I don't
understand why such a simple widget should become to be 1450 lines.

Also, I dislike the wrap_set API, I think it's awful.

--
Tom.


------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to