On Fri, 02 Mar 2012 06:54:58 +0000 (GMT) Rajeev Ranjan <rajee...@samsung.com> said:
> Hi Raster, > Following are my comments inlined to your queries. > -------------------------------------------------- > From: "Carsten Haitzler (The Rasterman)" <ras...@rasterman.com> > Sent: Thursday, March 01, 2012 4:34 PM > To: "Enlightenment developer list" <enlightenment-devel@lists.sourceforge.net> > Subject: Re: [E-devel] [Patch] Elementary: New custom widget Popup > > On Mon, 20 Feb 2012 20:07:24 +0900 woohyun<woo_hyun0...@naver.com> said: > > > > 1. why elm_popup_repeat_events_set(). yes - i see that it stops events > > repeating from notify up - but if u dont want them to repeat to parents of > > popup, then juts set the no propagate on the popup and that should do the > > trick... or is this meant to do something else - like work around something? > > This API is inline with the notify's API elm_notify_repeat_events_set. > When it is set to TRUE, then it does not have the blocking translucent area > around the content of popup and lower level objects around it > receive the mouse/touch events otherwise events are blocked. oh dear. you're right. thats so the wrong name as evas_object_repeat_events_set () does something different. this really is the inverse of BLOCKING events. must fix notify! ok - ignore this for now, but this will mean notify api changes and popup has to too. > > 2. you can append items, but not clear - that'd really be a minimum for > > this to function properly. other than that - no complaints. get those fixed > > and then just commit it. don't wait for me to re-review. > > > > Popup content ( Item list or full content set by app ) can be cleared using > elm_object_content_set(obj, NULL); Popup supports 2 type of contents ( full > content or List of items ), above approach is followed. hmmm - please add this to the documentation for popup then resend and i think it'll be good - just note that i will now change notify api, so please adjust popup notify repeat events api to match my changes before you re-send. (i've named it allow instead of repeat) > >> I just forward Rajeev's patch about new widget elm_popup :) > >> Please refer to the following message. > >> ================================================== > >> Hi, > >> > On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohen wrote: > >> > Your patch doesn't apply. Won't review. > >> This patch is based on latest svn revision 68142, so there should not be > >> any problem in applying it. In the last one, there was an issue in > >> applying for file doc/widget/Makefile.am as Pager's entry from Maklefile > >> was removed later. Thank you. Regards, > >> Rajeev > >> -----Original Message----- > >> From: "Rajeev Ranjan"<rajee...@samsung.com> > >> To: "Enlightenment developer > >> list"<enlightenment-devel@lists.sourceforge.net> Cc: "SUBRAMANIAM > >> CHINNACHAMY"<csm...@samsung.com> Sent: 12-02-17(?) 21:15:48 > >> Subject: Re: [E-devel] [Patch] Elementary: New custom widget Popup > >> Hi, > >> > On Thu, Feb 16, 2012 at 9:30 AM, Tom > >> > Hacohen<tom.haco...@samsung.com> wrote: Your patch doesn't apply. > >> > Won't review. > >> > > >> Some updates done during my patch creation & mailing time :( I will update > >> and post it soon ). > >> > On 16/02/12 16:38, Gustavo Sverzut Barbieri wrote:> aside from that I > >> > wonder what it offers on top of elm_layout. Maybe just add a canned > >> > layout as we do with others? > >> > > >> > how does it compare with inwin? > >> > >> inwin will cover the entire area of the parent window and it can expand by > >> setting its style to "minimal vertical". Popup can be very small to almost > >> full screen notification with partial transparent outer area. Popup also > >> supports screen orientations ( left,right,top, bottom etc, through Notify). > >> More over, there are marks to deprecate inwin ( refer the elm_win.h), so > >> there is no alternate to elm_popup widget. > >> > Isn't it better to provide styles for notify and inwin? > >> > > >> > > >> Popup is custom widget ( elc_popup - enhancement over elm_notify ), > >> simplifies application effort in showing either list or any other content > >> notification with title and action area buttons. Perhaps, one can develop > >> application with Evas & edje, but why do we have elm_layout, elm_separator, > >> naviframe etc... Basically it simplifies the development and provides > >> option to show notification with few lines of code( with uniform look & > >> feel ). > >> > Whenever sending these patches, please elaborate on the need, the > >> > existing solutions and why they do not fit or why they are not > >> > fixable. > >> > > >> Features supported by Popup can still be implemented by using the existing > >> widgets such as notify and custom layout having Title, content and action > >> buttons as its internal parts. These features are supported on almost all > >> leading UI widget tool kits as a widget similar to what Popup is supposed > >> to do. Reason is pretty simple as this enables user to get all commonly > >> used features like action button, title, content etc in a form of a single > >> widget which helps in application development. Popup widget is self > >> explanatory one ( common across all the UI toolkits ). its just matter of > >> whether every application should write few hundred lines of C & EDC code > >> or just do with few lines of code with popup. > >> > It's a layout inside an elm_notify if I understand it correctly, I don't > >> > understand why such a simple widget should become to be 1450 lines. > >> >> > >> > The code became large mostly because of the dynamic rearrangement support > >> > for the internal action buttons when deleted and support for multiple > >> > content parts including items. > >> > >> Popup supports List Items with individual item add/delete feature, not > >> just with that, also any layout/content . > >> > Also, I dislike the wrap_set API, I think it's awful. > >> > > >> This API has been added to help app developers control the wrapping of the > >> content description text. Most of the time, mixed wrapping should be fine > >> but if someone wants, word/char wrapping can be set using this API. > >> > On Feb 17, 2012 06:34 (GMT+05:30), Daniel Juyung > >> > Seo<seojuyu...@gmail.com> wrote: I think Rajeev needs to have a > >> > solid explanation why popup is needed even though we already have notify > >> > widget. Rajeev, can you describe that? Thanks in advance. > >> > Daniel Juyung Seo (SeoZ) > >> > >> Popup reuses notify capability to orient itself based on need and resizing > >> based on content minimum size. Encapsulating commonly used stuffs like > >> title, content and action buttons allow app developers to reuse the > >> commonly used features in the form of a widget. In addition to these > >> parts, popup has support for items which helps in quickly adding the list > >> of items and setting their internal content. Thank You. Regards, Rajeev > >> ------- Original Message ------- > >> Sender : Daniel Juyung Seo<seojuyu...@gmail.com> > >> Date : Feb 17, 2012 06:34 (GMT+05:30) > >> Title : Re: [E-devel] [Patch] Elementary: New custom widget Popup > >> I think Rajeev needs to have a solid explanation why popup is needed even > >> though we already have notify widget. Rajeev, can you describe that? > >> Thanks in advance. > >> Daniel Juyung Seo (SeoZ) > >> On Thu, Feb 16, 2012 at 11:43 PM, Tom Hacohen > >> <tom.haco...@samsung.com> wrote: On 16/02/12 16:38, Gustavo Sverzut > >> Barbieri wrote: > >> > On Thu, Feb 16, 2012 at 9:30 AM, Tom > >> > Hacohen<tom.haco...@samsung.com> wrote: > >> >> Your patch doesn't apply. Won't review. > >> > > >> > aside from that I wonder what it offers on top of elm_layout. Maybe > >> > just add a canned layout as we do with others? > >> > > >> > how does it compare with inwin? > >> > > >> > Isn't it better to provide styles for notify and inwin? > >> > > >> > Whenever sending these patches, please elaborate on the need, the > >> > existing solutions and why they do not fit or why they are not > >> > fixable. > >> > > >> > > >> It's a layout inside an elm_notify if I understand it correctly, I don't > >> understand why such a simple widget should become to be 1450 lines. > >> Also, I dislike the wrap_set API, I think it's awful. > >> -- > >> Tom. > >> ------------------------------------------------------------------------------ > >> Virtualization & Cloud Management Using Capacity Planning > >> Cloud computing makes use of virtualization - but cloud computing > >> also focuses on allowing computing to be delivered as a service. > >> http://www.accelacomm.com/jaw/sfnl/114/51521223/ > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> ------------------------------------------------------------------------------ > >> Virtualization & Cloud Management Using Capacity Planning > >> Cloud computing makes use of virtualization - but cloud computing > >> also focuses on allowing computing to be delivered as a service. > >> http://www.accelacomm.com/jaw/sfnl/114/51521223/ > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > > ------------------------------------------------------------------------------ > > Virtualization & Cloud Management Using Capacity Planning > > Cloud computing makes use of virtualization - but cloud computing > > also focuses on allowing computing to be delivered as a service. > > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ------- Original Message ------- > Sender : Carsten Haitzler<ras...@rasterman.com> > Date : Mar 01, 2012 16:34 (GMT+05:30) > Title : Re: [E-devel] [Patch] Elementary: New custom widget Popup > > On Mon, 20 Feb 2012 20:07:24 +0900 woohyun said: > > 1. why elm_popup_repeat_events_set(). yes - i see that it stops events > repeating from notify up - but if u dont want them to repeat to parents of > popup, then juts set the no propagate on the popup and that should do the > trick... or is this meant to do something else - like work around something? > 2. you can append items, but not clear - that'd really be a minimum for this > to function properly. other than that - no complaints. get those fixed and > then just commit it. don't wait for me to re-review. > > > I just forward Rajeev's patch about new widget elm_popup :) > > Please refer to the following message. > > ================================================== > > Hi, > > > On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohen wrote: > > > Your patch doesn't apply. Won't review. > > This patch is based on latest svn revision 68142, so there should not be > > any problem in applying it. In the last one, there was an issue in applying > > for file doc/widget/Makefile.am as Pager's entry from Maklefile was removed > > later. Thank you. Regards, > > Rajeev > > -----Original Message----- > > From: "Rajeev Ranjan"<rajee...@samsung.com> > > To: "Enlightenment developer > > list"<enlightenment-devel@lists.sourceforge.net> Cc: "SUBRAMANIAM > > CHINNACHAMY"<csm...@samsung.com> Sent: 12-02-17(?) 21:15:48 > > Subject: Re: [E-devel] [Patch] Elementary: New custom widget Popup > > Hi, > > > On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohen<tom.haco...@samsung.com> > > > wrote: Your patch doesn't apply. Won't review. > > > > > Some updates done during my patch creation & mailing time :( I will update > > and post it soon ). > > > On 16/02/12 16:38, Gustavo Sverzut Barbieri wrote:> aside from that I > > > wonder what it offers on top of elm_layout. Maybe just add a canned layout > > > as we do with others? > > > > > > how does it compare with inwin? > > > > inwin will cover the entire area of the parent window and it can expand by > > setting its style to "minimal vertical". Popup can be very small to almost > > full screen notification with partial transparent outer area. Popup also > > supports screen orientations ( left,right,top, bottom etc, through Notify). > > More over, there are marks to deprecate inwin ( refer the elm_win.h), so > > there is no alternate to elm_popup widget. > > > Isn't it better to provide styles for notify and inwin? > > > > > > > > Popup is custom widget ( elc_popup - enhancement over elm_notify ), > > simplifies application effort in showing either list or any other content > > notification with title and action area buttons. Perhaps, one can develop > > application with Evas & edje, but why do we have elm_layout, elm_separator, > > naviframe etc... Basically it simplifies the development and provides option > > to show notification with few lines of code( with uniform look & feel ). > > > Whenever sending these patches, please elaborate on the need, the > > > existing solutions and why they do not fit or why they are not > > > fixable. > > > > > Features supported by Popup can still be implemented by using the existing > > widgets such as notify and custom layout having Title, content and action > > buttons as its internal parts. These features are supported on almost all > > leading UI widget tool kits as a widget similar to what Popup is supposed to > > do. Reason is pretty simple as this enables user to get all commonly used > > features like action button, title, content etc in a form of a single widget > > which helps in application development. Popup widget is self explanatory one > > ( common across all the UI toolkits ). its just matter of whether every > > application should write few hundred lines of C & EDC code or just do with > > few lines of code with popup. > > > It's a layout inside an elm_notify if I understand it correctly, I don't > > > understand why such a simple widget should become to be 1450 lines. > > >> > > > The code became large mostly because of the dynamic rearrangement support > > > for the internal action buttons when deleted and support for multiple > > > content parts including items. > > > > Popup supports List Items with individual item add/delete feature, not just > > with that, also any layout/content . > > > Also, I dislike the wrap_set API, I think it's awful. > > > > > This API has been added to help app developers control the wrapping of the > > content description text. Most of the time, mixed wrapping should be fine > > but if someone wants, word/char wrapping can be set using this API. > > > On Feb 17, 2012 06:34 (GMT+05:30), Daniel Juyung > > > Seo<seojuyu...@gmail.com> wrote: I think Rajeev needs to have a solid > > > explanation why popup is needed even though we already have notify widget. > > > Rajeev, can you describe that? Thanks in advance. > > > Daniel Juyung Seo (SeoZ) > > > > Popup reuses notify capability to orient itself based on need and resizing > > based on content minimum size. Encapsulating commonly used stuffs like > > title, content and action buttons allow app developers to reuse the > > commonly used features in the form of a widget. In addition to these parts, > > popup has support for items which helps in quickly adding the list of items > > and setting their internal content. Thank You. Regards, Rajeev > > ------- Original Message ------- > > Sender : Daniel Juyung Seo<seojuyu...@gmail.com> > > Date : Feb 17, 2012 06:34 (GMT+05:30) > > Title : Re: [E-devel] [Patch] Elementary: New custom widget Popup > > I think Rajeev needs to have a solid explanation why popup is needed even > > though we already have notify widget. Rajeev, can you describe that? > > Thanks in advance. > > Daniel Juyung Seo (SeoZ) > > On Thu, Feb 16, 2012 at 11:43 PM, Tom Hacohen <tom.haco...@samsung.com> > > wrote: On 16/02/12 16:38, Gustavo Sverzut Barbieri wrote: > > > On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohen<tom.haco...@samsung.com> > > > wrote: > > >> Your patch doesn't apply. Won't review. > > > > > > aside from that I wonder what it offers on top of elm_layout. Maybe > > > just add a canned layout as we do with others? > > > > > > how does it compare with inwin? > > > > > > Isn't it better to provide styles for notify and inwin? > > > > > > Whenever sending these patches, please elaborate on the need, the > > > existing solutions and why they do not fit or why they are not > > > fixable. > > > > > > > > It's a layout inside an elm_notify if I understand it correctly, I don't > > understand why such a simple widget should become to be 1450 lines. > > Also, I dislike the wrap_set API, I think it's awful. > > -- > > Tom. > > ------------------------------------------------------------------------------ > > Virtualization & Cloud Management Using Capacity Planning > > Cloud computing makes use of virtualization - but cloud computing > > also focuses on allowing computing to be delivered as a service. > > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > > Virtualization & Cloud Management Using Capacity Planning > > Cloud computing makes use of virtualization - but cloud computing > > also focuses on allowing computing to be delivered as a service. > > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > Thank You. > Regards, > Rajeev > ------------------------------------------------------------------------------ > Virtualization & Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
