On Fri, Feb 17, 2012 at 10:56 AM, SHILPA ONKAR SINGH <shilpa.si...@samsung.com> wrote: > Hi Gustavo/Tom, > >>>how does it compare with existing Colorselector > (http://docs.enlightenment.org/auto/elementary/group__Colorselector.html) > > ColorPalette supports two major features. 1. Has theme based predefined set > of colors 2. Option for user to set own set of colors, > and color can be selected by clicking on any of the color rectangles, > basically color selector would be secondary > option to user to choose colors from if user does not find required color in > palette.
Okay, good. The next patch you send please include something this in the patch comment/email. >>>can't it be made together with colorselector? If you provide only > discrete colors instead of letting user define the color based on > RGB... maybe you could offer a mode? It would even make sense to offer > the last selected colors in the colorselector, and be possible to add > new colors to a pre-defined palette using it. > > Having color palette and color selector separately gives flexibility to > application in layouting and showing in screen ( mainly small screens ) > Application can very much pack these two widgets together and intergrate > their functionality without much extra effort. > Or, application can popup color selector if the color palette rectangle is > long pressed, select a color and update the color palette through provided > APIs. Then you just gave a reason why it should not be in a different widget: - you're not considering a common case - you're not considering consistent look and feel (every application must implement this and this causes fragmentation) Instead of a boolean flag, as I suggested, you should have an enumerate for "mode": - ELM_COLORSELECTOR_COMPONENTS = 1 - ELM_COLORSELECTOR_PALETTE = 2 - ELM_COLORSELECTOR_BOTH = 3 That way, if one wants to do what you suggest he creates 2 instances and sets the first and second mode on each, and does his stuff. But the recommended way is to set "BOTH" and let the platform (code or theme) define the look and feel for such thing. On a mobile it may be a pager that flips between the 2 modes, on a tablet or desktop it may show them side by side. > If application prefer to have own set of colors on top of theme color set, > its very much doable by increasing the item count ( example, increase from > default 5x2 to 5x3). > > I’m working on following enhancements on top of the current patch, > 1. add APIs to set/get Individual item color. > 2. Add longpressed signal for individual item. ok >>>Please elaborate as we really don't need even more widgets that > partially do one function :-( > > Its a widget with predefined set of theme based colors, with option to set > application specific frequently used color set. Color palettes are first > preference pickers than color selector which requires more time to select > specific colors. Totally agreed. Then one more reason they should be the same and provide easy way to switch between them. >>>Maybe add: > > >>elm_colorselector_palette_set(Evas_Object *o, const Eina_List *colors); > >>elm_colorselector_palette_grid_set(Evas_Object *o, unsigned > columns, unsigned rows); > > Having color palette separate provides flexibility to applications. So, I’m > not buying above point :) Neither I am buying yours ;-) You want to leave your extra work to every application writer (1 : N). That is bad. If you do it right and for once and for all, nobody needs to do all this logic in their application... not just effort, but also consistency and avoiding mistakes. -- Gustavo Sverzut Barbieri http://profusion.mobi embedded systems -------------------------------------- MSN: barbi...@gmail.com Skype: gsbarbieri Mobile: +55 (19) 9225-2202 ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
