On Fri, 2 Mar 2012 11:10:49 +0900 Jaehwan Kim <jaehwan.kim....@gmail.com> wrote:
> Hi > > Sorry about the toolbar broken. > I should have tested and reviewed it enough. > I reverted the elm_button.c and button.edc. It related to 68495. > It's not necessary whitout the revision. > I'll try to change the code for focusing later. And I'll send the patch. > > Thanks > -- > Jaehwan Kim. > > 2012년 3월 2일 금요일에 Michael Blumenkrantz님이 작성: > > > On Thu, 1 Mar 2012 11:14:46 -0800 > > "Enlightenment SVN" <no-re...@enlightenment.org <javascript:;>> wrote: > > > > > Log: > > > revert 68495 and all subsequent "toolbar refactoring" (rewriting) commits > > > because they broke toolbar use for everyone. in the future, rewrites like > > > this MUST be submitted as PATCHES, not direct commits. this allows > > > application authors to continue having fun writing code without suddenly > > > having broken widgets. I have left the newly committed edc, as it does > > not > > > seem likely to cause issues on its own. > > > > > > Author: discomfitor > > > Date: 2012-03-01 11:14:46 -0800 (Thu, 01 Mar 2012) > > > New Revision: 68586 > > > Trac: http://trac.enlightenment.org/e/changeset/68586 > > > > > > Modified: > > > trunk/elementary/src/lib/elm_toolbar.c > > > > > > > This commit was necessary as a result of the growing (and currently fairly > > substantial) number of complaints that "toolbar is broken!" and "why is my > > toolbar doing this?" > > > > As I have said in my commit message, let's, as a community, try to ensure > > that > > developers currently using our libraries can continue to do so without > > breaking > > the widgets and utilities they are accustomed to. > > For massive and complete rewrites/redesigns of existing codebases, always > > submit the proposed changes to the mailing list in patch form first. The > > ONLY > > exception to this is when you are either the initial or subsequent primary > > author of the code in question. > > > > Bottom line, we are a community of open source developers, and we should > > rely > > on each other more for reviews and help instead of trying to write/rewrite > > everything on our own. > > > > Thanks. > > > > Great, thanks for understanding. ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
