* Daniel Juyung Seo <seojuyu...@gmail.com> [2012-05-30 13:46:39 +0900]:
> On Tue, May 29, 2012 at 10:59 PM, Gustavo Sverzut Barbieri > <barbi...@profusion.mobi> wrote: > > On Tue, May 29, 2012 at 6:04 AM, Enlightenment SVN > > <no-re...@enlightenment.org> wrote: > >> Log: > >> fix case where user can specify item block size < 1; this also reveals an > >> api error since the param here should obviously be a uint. > >> > >> Author: discomfitor > >> Date: 2012-05-29 02:04:42 -0700 (Tue, 29 May 2012) > >> New Revision: 71498 > >> Trac: http://trac.enlightenment.org/e/changeset/71498 > >> > >> Modified: > >> trunk/elementary/src/lib/elm_genlist.c > >> > >> Modified: trunk/elementary/src/lib/elm_genlist.c > >> =================================================================== > >> --- trunk/elementary/src/lib/elm_genlist.c 2012-05-29 09:04:37 UTC > >> (rev 71497) > >> +++ trunk/elementary/src/lib/elm_genlist.c 2012-05-29 09:04:42 UTC > >> (rev 71498) > >> @@ -5447,6 +5447,7 @@ > >> ELM_CHECK_WIDTYPE(obj, widtype); > >> Widget_Data *wd = elm_widget_data_get(obj); > >> if (!wd) return; > >> + if (count < 1) return; > > > > If so, then EINA_SAFETY_ON_TRUE_RETURN(count < 1); > > > > it will play nice and warn the user. > > This is true. I will correct this. > > > > > I know the line before !wd is checked without such, but in that case > > ELM_CHECK_WIDTYPE would have complained anyway, making this check > > useless. > > I think ELM_CHECK_WIDTYPE does not guarantee widget data exists. How > do you think? Here we go. Most of the old checks for widget data were there just to account for race conditions, bad callbacks timing and stuff. An object's smart data should be guaranteed safe during a widget's whole life, period. Only if you the user goes on making evas_object_smart_data_set() on his own, on widgets, could he get screwed, but hey! My work on Elm's infra and widgets includes finding these wrong accesses and fixing them. > > Daniel Juyung Seo (SeoZ) > > > > > -- > > Gustavo Sverzut Barbieri > > http://profusion.mobi embedded systems > > -------------------------------------- > > MSN: barbi...@gmail.com > > Skype: gsbarbieri > > Mobile: +55 (19) 9225-2202 > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. Discussions > > will include endpoint security, mobile security and the latest in malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Lima Chaves Computer Engineer @ ProFUSION Embedded Systems ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
