On Wed, Mar 7, 2012 at 11:48 AM, Vincent Torri <vincent.to...@gmail.com> wrote:
> is that patch for win32 correct ?
I think yes, as the delete_me should be triggered only when the file
changed not the other way around...
> Index: eina_file_win32.c
> ===================================================================
> --- eina_file_win32.c (revision 68885)
> +++ eina_file_win32.c (working copy)
> @@ -922,7 +922,7 @@
>
> file = eina_hash_find(_eina_file_cache, filename);
> if (file &&
> - (file->mtime == mtime.QuadPart && file->length == length.QuadPart))
> + (file->mtime != mtime.QuadPart && file->length != length.QuadPart))
> {
> file->delete_me = EINA_TRUE;
> eina_hash_del(_eina_file_cache, file->filename, file);
>
>
> On Wed, Mar 7, 2012 at 11:40 AM, Enlightenment SVN
> <no-re...@enlightenment.org> wrote:
>> Log:
>> eina: don't reopen file when file didn't change.
>>
>> NOTE: we were leaking file at very high speed !
>>
>>
>> Author: cedric
>> Date: 2012-03-07 02:40:49 -0800 (Wed, 07 Mar 2012)
>> New Revision: 68924
>> Trac: http://trac.enlightenment.org/e/changeset/68924
>>
>> Modified:
>> trunk/eina/src/lib/eina_file.c
>>
>> Modified: trunk/eina/src/lib/eina_file.c
>> ===================================================================
>> --- trunk/eina/src/lib/eina_file.c 2012-03-07 10:39:30 UTC (rev 68923)
>> +++ trunk/eina/src/lib/eina_file.c 2012-03-07 10:40:49 UTC (rev 68924)
>> @@ -979,7 +979,7 @@
>> eina_lock_take(&_eina_file_lock_cache);
>>
>> file = eina_hash_find(_eina_file_cache, filename);
>> - if ((file) && _eina_file_timestamp_compare(file, &file_stat))
>> + if ((file) && !_eina_file_timestamp_compare(file, &file_stat))
>> {
>> file->delete_me = EINA_TRUE;
>> eina_hash_del(_eina_file_cache, file->filename, file);
>>
>>
>> ------------------------------------------------------------------------------
>> Virtualization & Cloud Management Using Capacity Planning
>> Cloud computing makes use of virtualization - but cloud computing
>> also focuses on allowing computing to be delivered as a service.
>> http://www.accelacomm.com/jaw/sfnl/114/51521223/
>> _______________________________________________
>> enlightenment-svn mailing list
>> enlightenment-...@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
>
> ------------------------------------------------------------------------------
> Virtualization & Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
Cedric BAIL
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
